Improvement to codebase to be more fluent with other modules

Hello
Thank you for your reply.

There may be a small misunderstanding about how pre_wp_mail is used.

Current situation
In mail-handler.php around line 103, SureMail applies the filter:
$pre_wp_mail = apply_filters( ‘pre_wp_mail’, null, $atts );
That runs inside <code class=””>MailHandler::process_mail() and checks whether another plugin has already short-circuited the call. It does not add a pre_wp_mail callback for SureMail itself.

Why SureMail’s handler often never runs
In suremails.php (around lines 55–69), SureMail only defines wp_mail when it doesn’t already exist. In standard WordPress, pluggable loads before plugins, so when SureMail loads, wp_mail usually already exists. In that case, SureMail never defines its own wp_mail, so <code class=””>MailHandler::handle_mail() (and logging) never runs. SureMail’s behaviour therefore still depends on plugin load order.

Proposed fix
Add a pre_wp_mail filter when wp_mail already exists so SureMail can intercept all calls. Keep the current wp_mail definition only for the rare case when it doesn’t exist.

With this approach, SureMail’s MailHandler and logging run regardless of plugin load order.
More details and a full example are in this gist: https://gist.github.com/svfcode/790f2dc6e6f4aab0688e9f58dce92d4b

Best regards

• This reply was modified 2 weeks, 5 days ago by sergefcleantalk.