Can’t disable button on woocommerce catalog page

  • Resolved lukiooo

    (@lukiooo)


    1 year ago

    Edit: somehow i can’t upload the screenshot, but my setting for pdf button are: post types and taxonomies to apply: all empty, position: shortcode

    If I understand correctly, with these settings the button should be shown only by using the [dkpdf-button] shortcode right? But with these settings the button is also shown on my product catalog/products categories page where there’s no shortcode injected. Any idea why is that?

    I know I can hide it with css, but I’m looking for more “elegant” solution.

    • This topic was modified 1 year ago by lukiooo.
    • This topic was modified 1 year ago by lukiooo.
Viewing 11 replies - 1 through 11 (of 11 total)
  • Plugin Author dinamiko

    (@dinamiko)

    1 year ago

    Hello @lukiooo,

    You’re right, I’ve just checked and I’m able to reproduce it, PDF button should not be there when “Use shortcode” position is selected, I take note to fix it for the next release, thanks.

    Plugin Author dinamiko

    (@dinamiko)

    10 months, 2 weeks ago

    Hello @lukiooo,

    Just to let you know that this issue was fixed in 2.2.0 version.

    Closing ticket, feel free to reopen it or create a new one at any time.

    simonk1

    (@simonk1)

    10 months, 1 week ago

    This still happens in 2.2.0

    Thread Starter lukiooo

    (@lukiooo)

    10 months, 1 week ago

    For me it seems to be fixed. After releasing 2.2.0., I removed my custom css and no button is shown on my product catalog/products categories pages while using the settings from the first post.

    • This reply was modified 10 months, 1 week ago by lukiooo.
    • This reply was modified 10 months, 1 week ago by lukiooo.
    simonk1

    (@simonk1)

    10 months, 1 week ago

    Still happening to me.

    Also the before/after content doesn’t seem to work.

    I’ve also noted that after uninstalling and reinstalling, the plugin remembers my logo and css changes (ie doesn’t to a full fresh install) I’ve cleared cache etc but it still happens. Any ideas?

    Plugin Author dinamiko

    (@dinamiko)

    10 months, 1 week ago

    Hello @simonk1,

    As of version 2.2.0 the PDF button should not be visible when it’s not selected in PDF Button / Post or Taxonomies to apply, if that’s not the case then please let me know the steps to reproduce and I’ll take a look, thanks.

    Also for the plugin remembering the settings, that’s because it currently does not remove them on plugin uninstall, I could create an option that when selected would remove the settings on plugin uninstall.

    • This reply was modified 10 months, 1 week ago by dinamiko.
    simonk1

    (@simonk1)

    10 months, 1 week ago

    It works if I have no Taxonomies selected and Use Shortcode – I can then add a shortcode button to the category after content, but the pdf creates no content.

    If I add product_cat taxonomy and Use Shortcode then I get the button twice. The new one works – but also appears on all category pages.

    Plugin Author dinamiko

    (@dinamiko)

    10 months ago

    Hello @simonk1,

    Thanks for the info, it seems the issue was that WooCommerce and archive pages weren’t checking the “shortcode only” position setting before displaying buttons.

    This will be included in the next release, would be great if you can give it a try and let me know if it works correctly now:
    https://github.com/Dinamiko/dk-pdf/releases/download/2.2.1-rc2/dk-pdf.zip

    simonk1

    (@simonk1)

    10 months ago

    This now works to hide/show the button.

    But, if IU put the shortcode in the description, top or bottom content of the category it produces a blank pdf.

    If it help the link to the blank pdf from the shortdode is:

    https://repairsandspares.co.nz/product-category/wrecking-stock/?pdf=2038

    While the working link from the Before content option of the plugin is :

    https://repairsandspares.co.nz/product-category/wrecking-stock/?pdf=product_cat_98

    Plugin Author dinamiko

    (@dinamiko)

    10 months ago

    Hello @simonk1,

    I’ve found the issue, the pdf button from shortcode in archive pages was using the single template instead of the archive one, now the URL should look the same as the one from Before content (?pdf=product_cat_98).

    Here is the package with the fix, would we great if you can give it a try, thanks:
    https://github.com/Dinamiko/dk-pdf/releases/download/2.2.1-rc3/dk-pdf.zip

    • This reply was modified 10 months ago by dinamiko.
    simonk1

    (@simonk1)

    10 months ago

    Nice one! Works perfectly

    Thanks heaps 🙂

Viewing 11 replies - 1 through 11 (of 11 total)

The topic ‘Can’t disable button on woocommerce catalog page’ is closed to new replies.