Try adding:
// set content width
if ( ! isset( $content_width ) ) $content_width = 514;
to your theme’s functions.php file
Hi esmi,
I have tried that with no luck.
Disabled and re-enabled the theme as well, do I need to delete the unit test content and re-upload it?
max-width of images in style.css 500px content_width 514
edit:
All pages, posts, images delete, theme de-activated, re-activated, re-imported test data.
Trac Ticket
Still the same 🙁
David
I don’t think it will impact on images that have been imported via the test data. The point is to try and control the width of images uploaded on a site post theme activation. The theme reviewers will specifically check to see if you’ve included this line in functions.php.
The test data is good but it’s not perfect and it certainly doesn’t work flawlessly with every theme.
Looking at your Images test page, I don’t see any issues with your display because you’re also using a CSS max-width on your images as a fallback but the reviewer will still want to see $content_width set.
( I assume you’ll actually want to set $content_width to 640 and not 514 as I suggested previously).
FWIW, there was some debate about this point on the theme_review list a while back, so you could always ask for clarification of this point on the list. While you’re there, you might also want to ask for clarification on the eligibility of themes based on Twenty Ten. I know some themes have been rejects as “clones” before now but as I’m not a reviewer, I’m not sure where, or how, the line is drawn.
Esmi, the theme width is 724, sidebar 170 plus margins 40, that is where the 514px content width comes from.
It is my first submitted theme attempt, I searched for twenty ten clones and there are three “based on twenty ten”, so I cannot see that as a reject reason, it does not look like twenty ten, and there are a few new theme options.
It is not clear from the unit tests what the images are meant to do, I was not sure if the overflow should be hidden.
I will leave it for the reviewer, and I have added the changed files to trac!
Thanks for your help.
David
that is where the 514px content width comes from.
Fair enough 🙂 I just noticed that you’d set a max-width of 640px on images in the #content area in the stylesheet.
I cannot see that as a reject reason
As I said, it’s not clear cut as themes are judged on a case-by-case basis. If you’re adding new theme options, you might be OK.
It is not clear from the unit tests what the images are meant to do, I was not sure if the overflow should be hidden.
I think the review team are trying to walk a fine line between maintaining certain standards whilst trying not to be over-dictatorial. So whilst some “features” are mandated, others are left to the developer’s discretion with the only over-riding concern being that the theme doesn’t break if, for example, an over-large image is used.
Thanks for your help.
No problem. I’ve been through the new review process twice now and I’m currently trying to get a 3rd theme ready for submission. It’s a tough process. Good luck. 🙂
Esmi Thanks!
The max-width has been updated in the 1.2 version I submitted, the images thing did throw me.
It was only created for ‘something to do’, after reading a topic here where an older (2007) theme had a few deprecated calls.
I downloaded the original theme and it had base64 encrypted code, and the authors website no longer exists, so I just used the look and feel to create an updated theme.
If it fails then I can just host it on my own website, positives are for me finding the ‘theme test’ and ‘unit test’ websites, plugin and functions.
I have marked this topic as resolved and will wait to see it it passes.
David
