Suggestion for Collapsible TOC without extra JS

Resolved Arya Dhiratara
(@aryadhiratara)

3 years, 12 months ago
Hi Marc,

First of all, I love your plugin! I love the minimalistyc approach and really amazed since I realized that I can hook it in GP block elements and Blocksy Content Block. It reads and renders the headings beautifully in each single posts.

Since I like a collapsible TOC, and used to use html block to create my TOC manually. I can make it collapsible without adding extra js file using onclick function.

As I love your plugin so much, I try to make a few adjustments in the simpleTOC’s plugin.php (and some other files to make the the collapsible TOC can be use as an option in the page editor), it works nicely. Perhaps you want to take a look? I’m sure this would satisfy users who also like collapsible TOC.

I have upload the file in my google drive, can you share your email so I can share the file? I don’t know if it’s okay to share google drive url here.

Thank you.
- This topic was modified 3 years, 12 months ago by Arya Dhiratara.
- This topic was modified 3 years, 12 months ago by Arya Dhiratara.

Viewing 9 replies - 1 through 9 (of 9 total)

Plugin Author Marc Tönsing
(@marcdk)

3 years, 12 months ago

Please use GitHub https://github.com/mtoensing/simpletoc and provide a pull request.

Thread Starter Arya Dhiratara
(@aryadhiratara)

3 years, 12 months ago

Hi Marc,

Really sorry, since I’m not that familiar with github, I don’t know how to pull request correctly. I uploaded it in my repo just now: https://github.com/aryadhiratara/simpletoc-collapsible, please let me know if you have download it, I will delete it right after it.

Thank you

Plugin Author Marc Tönsing
(@marcdk)

3 years, 12 months ago

Hi,

in the top-right corner on https://github.com/mtoensing/simpletoc is a “fork”-button. Please make your changes in this fork and commit them. Then after you have tested your changes, provide a pull request. This is a button next to your commits.

Thread Starter Arya Dhiratara
(@aryadhiratara)

3 years, 12 months ago

Hi Marc,

I have fork it to https://github.com/aryadhiratara/collapsible-simpletoc. After I edit the necessary files, what option should I choose when I commit changes to a file, “Commit directly to the master branch.” or “Create a new branch for this commit and start a pull request.”?

Plugin Author Marc Tönsing
(@marcdk)

3 years, 12 months ago

“Create a new branch for this commit and start a pull request”

Thread Starter Arya Dhiratara
(@aryadhiratara)

3 years, 12 months ago

Done.

Plugin Author Marc Tönsing
(@marcdk)

3 years, 12 months ago

Hi, I am really sorry, but now you opened 4 PR in your own copy/fork of the repo. But if you don’t mind, I think it is better to understand the process of PR in GitHub to contribute to open-source projects.

Here is a step by step guide: https://codex.so/fork-and-pull-en

The result will be a pull request in my repo with you as an author and a separate branch I can look at and see what you have changed. You can even update that pull request after that. There have been many successful pr in the past: https://github.com/mtoensing/simpletoc/pulls?q=is%3Apr+is%3Aclosed

If your PR appears here in this list, you are done: https://github.com/mtoensing/simpletoc/pulls

Thread Starter Arya Dhiratara
(@aryadhiratara)

3 years, 12 months ago

Finally it appears here https://github.com/mtoensing/simpletoc/pulls.

This is the very first time for me to pull a request of somebody’s project of github 🙂

Plugin Author Marc Tönsing
(@marcdk)

3 years, 12 months ago

I will close this because the discussion is not where it belongs: GitHub: https://github.com/mtoensing/simpletoc/pull/15

Viewing 9 replies - 1 through 9 (of 9 total)

The topic ‘Suggestion for Collapsible TOC without extra JS’ is closed to new replies.