[NSFW] Single Line comment not removed
-
Hi @maximalsparen,
I hope you are doing good today, and thank you for reaching out to us.
The file mentioned is a WordPress core file, and it is recommended not to edit the core files in any situation.
I checked this at my end but could not notice any javascript error in the browser console when trying to update WordPress core with Hummingbird Asset Optimization active.
Can you please share a screenshot of the error to get a better idea about the issue?
We will be looking forward to hearing back from you.
Kind Regards,
Nebu JohnHi John @wpmudevsupport14 !
I created a copy of my wordpress blog with that Javascript issue in the console log.
https://bugwordpress.maximalsparen.com/And here is the hummingbird config which I use:
{ "version": "3.3.0", "plugins": [ "better-images\/better-images.php", "coupon-reveal-button\/spbcta-plugin.php", "custom-css-js\/custom-css-js.php", "duplicate-post\/duplicate-post.php", "duplicator\/duplicator.php", "email-encoder-bundle\/email-encoder-bundle.php", "emoji-settings\/emojisettings.php", "health-check\/health-check.php", "hummingbird-performance\/wp-hummingbird.php", "luckywp-table-of-contents\/luckywp-table-of-contents.php", "media-library-plus\/maxgalleria-media-library.php", "media-library-plus\/mlp-reset.php", "public-post-preview\/public-post-preview.php", "sticky-menu-or-anything-on-scroll\/sticky-menu-or-anything.php", "superb-blocks\/plugin.php", "superb-helper\/superb-helper.php", "superb-recent-posts-with-thumbnail-images\/superb-recent-posts-with-images.php", "superb-social-share-and-follow-buttons\/superb-social-share-and-follow-buttons.php", "superb-tables\/superb-tables.php", "wordfence\/wordfence.php", "wordpress-seo\/wp-seo.php", "wp-hide-security-enhancer\/wp-hide.php", "wp-statistics\/wp-statistics.php" ], "network_plugins": false, "theme": "magazinely", "settings": { "minify": { "enabled": true, "use_cdn": false, "log": false, "file_path": "", "minify_blog": false, "view": "basic", "type": "speedy", "do_assets": { "styles": true, "scripts": true }, "block": { "scripts": [], "styles": [] }, "dont_minify": { "scripts": [ "jquery", "spbcta-nm-script", "magazinely-custom-js-jquery" ], "styles": [ "spbtbl-stylesheet", "spbsm-lato-font", "global-styles" ] }, "dont_combine": { "scripts": [ "jquery", "jquery-core", "jquery-migrate", "spbcta-nm-script", "eeb-js-frontend", "stickyAnythingLib", "eeb-js-ajax-ef", "stickThis", "magazinely-navigation", "magazinely-skip-link-focus-fix", "magazinely-foundation-js-jquery", "magazinely-custom-js-jquery", "magazinely-owl-slider-js-jquery", "wp-embed" ], "styles": [ "spbtbl-stylesheet", "spbsm-lato-font", "global-styles" ] }, "position": { "scripts": [], "styles": [] }, "defer": { "scripts": [], "styles": [] }, "inline": { "scripts": [], "styles": [] }, "nocdn": { "scripts": [], "styles": [] }, "fonts": [], "preload": { "scripts": [], "styles": [] }, "async": { "scripts": [], "styles": [] } } } }If you need more information please let me know.
Many thanks,
Best regards
MaxThanks for sharing the page.
https://monosnap.com/file/svYzPRRuBKj07zVLBUhI5HzCufOknr
I couldn’t see any issue in the browser console, can you verify if it is happening in any Specific browser or maybe only when you are logged-in?
Best Regards
Patrick FreitasHi Patrick!
Yes, you are right. It only happens when i’m logged-in. Then i’m getting this error see attached screenshot https://ibb.co/6gFBWs9
Best regards,
MaxCould you please send me an email to contact@wpmudev.org using this template:
Subject: "Attn: Patrick Freitas" Message: https://wordpress.org/support/topic/single-line-comment-not-removed/Best Regards
Patrick Freitas
The topic ‘[NSFW] Single Line comment not removed’ is closed to new replies.
(@maximalsparen)
4 years, 3 months ago
Hi!
Every time I update wordpress core (tested with the latest version of wordpress and before; at least since wordpress 5.8) there is single line comment in (wp-includes/theme.php) where I get an Javascript error (error end of input) when the hummingbird JS minifiying process is activated (Asset optimization for javascript is active). As this single line comment will not be deleted, or at least this is creating the javascript error in combination with asset optimization for javascript active.
My workaround is, every time I update wordpress core. I remove this comment from the PHP File. It would be great if the devs from hummingbird can fix this issue.
Best regards
Max