“Order” section fields show in the “shipping” section

  • Resolved Simon Kane

    (@simonkane)


    5 years, 3 months ago

    It appears there is a typo bug in:
    /wp-content/plugins/flexible-checkout-fields/classes/plugin.php at line 128
    Lines 120-131 are shown here. Note “after_shipping” is twice.

    		add_action( 'woocommerce_admin_order_data_after_billing_address', array(
			$this,
			'addCustomBillingFieldsToAdmin'
		) );
		add_action( 'woocommerce_admin_order_data_after_shipping_address', array(
			$this,
			'addCustomShippingFieldsToAdmin'
		) );
		add_action( 'woocommerce_admin_order_data_after_shipping_address', array(
			$this,
			'addCustomOrderFieldsToAdmin'
		) );

    Changing the duplicated reference
    from: woocommerce_admin_order_data_after_shipping_address
    to: woocommerce_admin_order_data_after_order_details
    Makes the fields display properly in the left column (but they are not editable).

    It appears that _order_* fields are not handled the same as _billing_* and _shipping_* by Woo itself, and there isn’t any filter/action for it obvious to me.
    Your insights on that will be appreciated.

    P.S. I have made my _shipping_* FCFs editable with a simple filter on: woocommerce_admin_shipping_fields
    Works fine — code available on request, but we are getting off-topic of the typo-bug.

    The page I need help with: [log in to see the link]

Viewing 7 replies - 1 through 7 (of 7 total)
  • Plugin Support Tomasz WP Desk

    (@tomaszwp)

    5 years, 3 months ago

    Hello @simonkane

    Thanks for that note. But I am afraid the code will remain as it is for now because it is not a minor change.

    Editing WooCommerce fields works. FCF fields are edited at the bottom in a separate section.
    Editing additional fields in the order

    And we will not change that for now.

    We are planning changes in the WP dashboard and there is a chance that we will take this suggestion into account.

    Thread Starter Simon Kane

    (@simonkane)

    5 years, 3 months ago

    I knew I shouldn’t have tried to mention two issues at once.

    Are you saying that the OBVIOUS and MINOR typo-bug at the top of my OP will not be fixed? It is a one-token fix (use the correct action name for fields in the ‘order’ section).

    —————-
    I am also NOT talking about editing the field settings (not sure if that’s what you replied as), but editing the the field’s value saved in the current order when using admin “order edit”. The issues with such in the admin order edit screen have a lot more to do with Woo’s klunky coding of the order details sections than anything in FCF.

    Your editing link reference (which is to the Pro version) is unclear to me, although the CSS snippet there is already implemented per my other ticket:
    https://wordpress.org/support/topic/admin-order-edit-billing-shipping-field-layout-2/#post-13841233

    Possibly you implement “editing FCF field values in admin” as part of the Pro?
    I can understand such a business decision –
    and that’s also why I didn’t post my code to enable such editing.

    Plugin Support Tomasz WP Desk

    (@tomaszwp)

    5 years, 3 months ago

    Hello @simonkane

    We correct the errors reported to us. But not all of them require immediate intervention and updating. As I mentioned before – we are also planning other changes in this area and the update will cover the whole.

    We added the mentioned change (the one with the snippet) to the documentation as soon as you reported that issue to us.

    Editing the fields in the order is available in the PRO version (as you have noticed). I apologize if the previous answer was confusing.

    Thread Starter Simon Kane

    (@simonkane)

    5 years, 3 months ago

    Hi!

    Yes, it was confusing – and as I mentioned, I shouldn’t have stuck two things in the one ticket. They were related from where I sat, but I can certainly see now that they’re really not.

    And I’ll keep my bit of edit magic to myself for ya. <grin>

    Thread Starter Simon Kane

    (@simonkane)

    5 years ago

    I am disappointed, but not at all surprised, that the typo that causes the fields to display in the wrong section has not been resolved even in the major version (3.0) just released.

    Plugin Support Tomasz WP Desk

    (@tomaszwp)

    5 years ago

    Hello @simonkane

    We do not plan to change the place where the fields will be shown in the order edition. The fields here work as intended. This is not an error or a typo. Such code is added on purpose.

    We will help with fixing issues or configuring the plugin. But we will not change what works from the beginning.

    Thread Starter Simon Kane

    (@simonkane)

    5 years ago

    It appears that you have not even looked at the code.

    You have now changed your excuse from “it is not a minor change” to “The fields here work as intended”. I find that interesting.

    I do hereby revoke my self-imposed restriction on sharing my enhancement code as per open source licensing guidelines.

Viewing 7 replies - 1 through 7 (of 7 total)

The topic ‘“Order” section fields show in the “shipping” section’ is closed to new replies.