Issue with embedding ondrive documents

Resolved arafail
(@arafail)

5 years, 9 months ago

Hello!
I am using your plugin, as I have mentioned before, with almost perfect success, but I do have some issues with it. More to the point, I cannot embed onedrive documents into my posts. Embedding folders with images works fine but a simple spreadsheet does not.

Here is the example: https://www.citizenmedia.ro/cum-criptezi-o-partitie-de-sistem-cu-bitlocker-in-windows-10/

In this document you will find the following strings:
Google Drive embed: – google drive spread sheet – works
OneDrive embed: – the same spreadsheet from above, but from a onedrive source – does not work, it shows an empty iframe
Embeding OneDrive folder: – a onedrive folder, containing images – works.

My AMP plugin is version 1.5.5 and my WordPress version is 5.5.1-alpha-48833.

The page I need help with: [log in to see the link]

Viewing 7 replies - 1 through 7 (of 7 total)

James Osborne
(@jamesosborne)

5 years, 9 months ago

Have you tried to embed the image using the OneDrive embed code snippet provided? If so you’ll need to enable the “Include HTML tags” option, which from my testing worked fine.

Without including the HTML tags the image may not render when using the default WordPress editor, not just for AMP URLs.

Thread Starter arafail
(@arafail)

5 years, 9 months ago

Hello James!
I am not talking about images but Excel spreadsheets uploaded to OneDrive or Word documents.
There are no options like the one in your example for these.

https://prnt.sc/u3erfr

https://prnt.sc/u3es2b

James Osborne
(@jamesosborne)

5 years, 9 months ago

Apologies, my mistake. We may need to raise a GitHub issue for this or investigate further. In the meantime can you try and add the below attributes within your iFrame tag while I check this further?:
sandbox="allow-scripts allow-forms allow-same-origin"

Thread Starter arafail
(@arafail)

5 years, 9 months ago

This does indeed seem to work, thank you very much!
I will develop a shortocode that will append this parameters automatically.
Here is the result: https://www.citizenmedia.ro/cum-criptezi-o-partitie-de-sistem-cu-bitlocker-in-windows-10/
Thanks again!

James Osborne
(@jamesosborne)

5 years, 9 months ago

No problem at all, glad to hear it. As an AMP user for a while you might be interested in testing out the release candidate of the plugin v2.0 on a staging or local site, we’d love to hear your feedback.

And you may also want to submit your AMP website for consideration in the showcase listings for our new website, which is due soon.

Thread Starter arafail
(@arafail)

5 years, 9 months ago

I am definitely interested and yes, we will submit our website, but we still have some thing to workout before it is 100%.
This one drive bug is one less problem. Thanks again!

James Osborne
(@jamesosborne)

5 years, 9 months ago

Sounds great! We’ve also created the GitHub issue to address the sandbox values.
https://github.com/ampproject/amp-wp/issues/5256

Viewing 7 replies - 1 through 7 (of 7 total)

The topic ‘Issue with embedding ondrive documents’ is closed to new replies.

Tags