Booking time error

  • Resolved paxmedia

    (@paxmedia)


    6 years, 2 months ago

    Hi,

    The latest update introduced a nasty bug, where some bookings show up with the wrong time (+1 hour) in the booking overview & google calendar. If you go to the same booking and edit the post, the time is correct.

    Visual clarification:
    http://marijedouma.nl/SLN_booking_error_time.png

    The strangest thing it isn’t happening to all bookings; and I’m unable to reproduce the exact reason. Tried disabling all other plugins, default theme etc. Doesn’t fix the issue.

    Some more details:
    – WordPress 5.3.2 on PHP 7
    – plugin 3.36.6
    – Time setting in wordpress is set to “Amsterdam” (UTC+1) as is the google calendar syncing to it.

    The page I need help with: [log in to see the link]

Viewing 8 replies - 1 through 8 (of 8 total)
  • Plugin Author Dimitri Grassi

    (@wordpresschef)

    6 years, 2 months ago

    Hi,

    I’ve checked your website and it seems working.

    Thread Starter paxmedia

    (@paxmedia)

    6 years, 2 months ago

    Yes, it works… but as you can see in the image I’ve sent there’s a bug with the actual bookings: the time is incorrect in both the google calendar & bookingoverview.

    Is there a way to revert to 3.32 or something? Because the error didn’t occur back then.

    Thread Starter paxmedia

    (@paxmedia)

    6 years, 2 months ago

    Hi @wordpresschef any chance you checked the screenshots in my first post? Seems you misread that one and now no answer.
    Hope to hear from you!

    Anonymous User 17211325

    (@anonymized-17211325)

    6 years, 2 months ago

    @paxmedia I just updated from 3.34 to 3.36 and have the same problem too. Going to get started on debugging this now, will share what I find.

    Anonymous User 17211325

    (@anonymized-17211325)

    6 years, 2 months ago

    The problem is with date/times after March 08 2020, which is the DST (daylight savings time) change. Incorrect formatting is being introduced from the SLN_DateTime class. I came up with a fix for this function to display correct time in the admin.

    But upon testing, there remains problem with google calendar. The scheduled event is the correct time, but the event note/comment shows the time +1 hour.

    Will post when I solve this fully

    • This reply was modified 6 years, 2 months ago by Anonymous User 17211325.
    Anonymous User 17211325

    (@anonymized-17211325)

    6 years, 2 months ago

    Okay, tracing that was easier than expected. Use the follow changes are your own risk.

    /wp-content/plugins/salon-booking-system/src/SLN/DateTime.php, Line 23

    Before:
    $static_wp_timezone = new DateTimeZone( self::getWpTimezoneString() );

    After:
    //$static_wp_timezone = new DateTimeZone( self::getWpTimezoneString() );

    /wp-content/plugins/salon-booking-system/src/SLN/TimeFunc.php, Line 19

    Before:
    $static_wp_timezone = new DateTimeZone( self::getWpTimezoneString() );

    After:
    //$static_wp_timezone = new DateTimeZone( self::getWpTimezoneString() );

    Anonymous User 17211325

    (@anonymized-17211325)

    6 years, 2 months ago

    @paxmedia The new version of the plugin (3.36.7) fixes the issue properly, my method was a bit of a hack 🙂

    Thread Starter paxmedia

    (@paxmedia)

    6 years, 2 months ago

    Nice!

    New version fixes it perfectly.
    Many many thanks 🙏🏻

Viewing 8 replies - 1 through 8 (of 8 total)

The topic ‘Booking time error’ is closed to new replies.