hide title conflict

  • Resolved thomask

    (@thomask)


    6 years, 7 months ago

    I love your plugin and i love the way you’ve solved how to hide the title, if it is not necessary. I myself did it with two custom fields in sidebar (show title && custom title)
    The problem is, that the way you did it conflicts with some other plugins, e.g breadcrumb-navxt – when i hide the title with your plugin, the page title is missing also from the breadcrumb.

    I have tried to add is_main_query() to your editorskit_hide_title function, which should help for some cases, but for this problem it does not help. I wonder that maybe there is a problem also in the breadcrumb plugin, if it uses the main query instead of secondary one.

    But if you could check it, it would be great.

Viewing 4 replies - 1 through 4 (of 4 total)
  • Thread Starter thomask

    (@thomask)

    6 years, 7 months ago

    just for info if someone has the same problem – sometimes it can be “solved” by turning the filter off before the other plugin call and then turn it on back. E.g. for my breadcrumb problem, you can use:

    	    remove_filter( 'the_title', 'editorskit_hide_title', 10, 2 );
		bcn_display();       
	    add_filter( 'the_title', 'editorskit_hide_title', 10, 2 );
    Jeffrey Carandang

    (@phpbits)

    6 years, 7 months ago

    @thomask Thanks a lot for reporting this issue and providing a solution. I’ll take a look on what I can do on the EditorsKit code side if I can provide compatibility with breadcrumbs plugin. For the meantime, you can use the code you’ve provided to have a simple fix. Thanks again!

    Thread Starter thomask

    (@thomask)

    6 years, 7 months ago

    I have found more serious problem with this issue – the title is hidden also from admin area when adding the link to document with a hidden title.

    It is strange and IMO a bug in WordPress, because you are calling !is_admin condition, but as i am googling it, the problem is, that that add link popup uses external json call, e.g. see
    https://stackoverflow.com/questions/39115564/wordpress-hook-filter-to-process-link-inside-a-post/39176559
    I will try to find the filter how to solve it, but maybe you will be quicker as you are clearly more experienced dev. 🙂

    Jeffrey Carandang

    (@phpbits)

    6 years, 7 months ago

    @thomask Fixed the issue with REST API calls and will be available on the next update. Thanks a lot for reporting this issue.

Viewing 4 replies - 1 through 4 (of 4 total)

The topic ‘hide title conflict’ is closed to new replies.