Wrong label

  • Resolved giannic

    (@giannic)


    7 years, 1 month ago

    Hi,

    in the file templates/checkout/form-summary.php line 23, I found this

    <span class=”llms-label”><?php _e( ‘Terms’, ‘lifterlms’ ); ?>:</span>
    <span class=”price-regular”><?php echo $plan->get_price( ‘price’ ); ?></span>

    but I think that the label is wrong, It should be a price, I mean that the right code has to be this

    <span class=”llms-label”><?php _e( ‘Price’, ‘lifterlms’ ); ?>:</span>
    24 <span class=”price-regular”><?php echo $plan->get_price( ‘price’ ); ?></span>

    because the class is price and the label has to be “price”

    what do you think about?

    Regards
    Giovanni

Viewing 3 replies - 1 through 3 (of 3 total)
  • Thomas Patrick Levy

    (@thomasplevy)

    7 years, 1 month ago

    @giannic,

    You’re ignoring all the other information that follows the price, namely expiration details.

    This is NOT just a place where the price is displayed. All of the information (all of the “Terms”) of the subscription the student is about to enter into is being displayed here. So no, this isn’t the wrong label.

    Of course we can argue about whether or not this is the “correct” language to use here or not and while I do like arguing, I only like to argue about things that are impossible to customize and you can very easily “translate” this language on your site should you disagree with me.

    Here’s how: https://lifterlms.com/docs/how-do-i-customize-the-text-of-lifterlms-buttons-and-more/

    If you really feel that this is language that should be adjusted please open a bug report in GitHub and we’ll discuss the language with the team in a future meeting and determine if this is something that we should consider changing: https://github.com/gocodebox/lifterlms/issues

    Best,

    Thread Starter giannic

    (@giannic)

    7 years, 1 month ago

    Hi Patrick,

    I want explain that my post wasn’t a criticism but I wanted to your opinion and discuss with you if you believed that it was a mistake because I think that this plugin is fantastic and I wanted to improve it

    so that’s all

    Best

    Thomas Patrick Levy

    (@thomasplevy)

    7 years, 1 month ago

    @giannic,

    Criticism welcomed and as I noted, if you want me to consider changing the codebase please open an issue on GitHub where we can discuss it further. I try to keep this support forum to support issues. Changes, feature request, bug reports, etc… are best kept to our preferred avenue of communication about this things. In this case it’s GitHub. Open a new issue and propose some changes (noting that this isn’t just a price field) and we’ll consider them.

    Best,

Viewing 3 replies - 1 through 3 (of 3 total)

The topic ‘Wrong label’ is closed to new replies.