jQuery version check is faulty

  • Resolved yelbaev

    (@yelbaev)


    7 years, 6 months ago

    Hello Devs of Afterpay

    I your plugin in file afterpay-gateway-for-woocommerce\js\afterpay.js you perform a check for jQuery version like this:

    
    if (typeof jQuery === 'undefined' || parseFloat(jQuery.fn.jquery) < 1.7) {
        Afterpay.loadScript('https://ajax.googleapis.com/ajax/libs/jquery/1.12.4/jquery.min.js', function() {
            var jQuery_1_12_4 = jQuery.noConflict(true);
            Afterpay.init(jQuery_1_12_4);
        });
    } else {
        Afterpay.init(jQuery);
    }

    That is wrong, because version ‘1.12.4’ processed by parseFloat becomes 1.12, and 1.12 is less than 1.7 mathematically. But version-wise it’s not

    This causes website to load jQuery twice

    Please fix this

Viewing 1 replies (of 1 total)
  • Plugin Author Afterpay

    (@afterpayit)

    7 years, 6 months ago

    Hi yelbaev,

    Thanks for reporting this behaviour. Our engineers are now aware of this and are working to address it. This is the first time this particular behaviour has been reported.

    Any updates to the Afterpay Gateway for WooCommerce plugin will become available through the standard plugin manager in the WordPress admin.

    If you would like to request a member of the support team to assist in troubleshooting this individual case, please create a support ticket here:
    https://help.afterpay.com/hc/en-au/requests/new?ticket_form_id=193406

    Thank you.

Viewing 1 replies (of 1 total)

The topic ‘jQuery version check is faulty’ is closed to new replies.

Tags