Interference with site-origin accordion widget

Resolved huegelkind
(@mpzimmer)

8 years, 2 months ago

Hi,

when wp-Typography is activated, the + sign (indicator to klick to unfold the accordion) in site-origin accordion widget is replaced by an ugly-looking string of characters and special characters. When wp-Typography is deactivated, everythings working fine. (excep wp-Typography, of course)

Thank you for your help!

wp-Typography-Version: 5.2.4
site-origin widget bundle Version 1.11.4
PHP Version 7.1.14
OS Windows 10 Version 1709 Build 16299.248
Browser MS Edge 41.16299.248.0 or Chrome 63.0.3239.132

The page I need help with: [log in to see the link]

Viewing 10 replies - 1 through 10 (of 10 total)

Plugin Author pepe
(@pputzer)

8 years, 2 months ago

@mpzimmer: Can you deactivate wp-Typography on that site please? I’d like to look at the raw markup. (I assume the source code to this accordion widget is not publicly available?)

Thread Starter huegelkind
(@mpzimmer)

8 years, 2 months ago

deactivated.

Plugin Author pepe
(@pputzer)

8 years, 2 months ago

The problem is a markup error in the accordion widget: <span class="sow-icon-ionicons" data-sow-icon="&#xf218" >.

The entity in the data-sow-icon attribute is lacking the final ;, which is why the & gets encoded as & by wp-Typography’s HTML parser. Browsers are more lenient here.

Thread Starter huegelkind
(@mpzimmer)

8 years, 2 months ago

for the code, there could something to be found on github https://github.com/siteorigin/so-widgets-bundle

Thread Starter huegelkind
(@mpzimmer)

8 years, 2 months ago

OK, I’ll pass this information over to site origin, hoping that they’ll fix it.
Thank you for warp-9-support!

Plugin Author pepe
(@pputzer)

8 years, 2 months ago

The problem lies in https://github.com/siteorigin/so-widgets-bundle/blob/24dcccafd1164daf8d99b5e2081734ff31102b83/icons/ionicons/filter.php, the whole bundle is missing the ;.

Thread Starter huegelkind
(@mpzimmer)

8 years, 2 months ago

Hello Pepe,

thank you again for your most valuable help. I’ve contacted site origin’s support, but they didn’t react yet. (well, I don’t expect wonders, maybe they’ll need some time).
Can you imagine some kind of workaround for this issue?

Plugin Author pepe
(@pputzer)

8 years, 2 months ago

@mpzimmer: Unfortunately, there is no workaround. However, I reported the issue on GitHub and they have already fixed it in the develop branch. Not sure when they’ll do a new release, though.

Thread Starter huegelkind
(@mpzimmer)

8 years, 2 months ago

Well, your work clearly has earned a five star rating!
Thanks a lot!

Michael

Plugin Author pepe
(@pputzer)

8 years, 2 months ago

Thank you, @mpzimmer. (If you find the time to write a review for wp-Typography, I’d of course appreciate that very much.)

Viewing 10 replies - 1 through 10 (of 10 total)

The topic ‘Interference with site-origin accordion widget’ is closed to new replies.