{"id":8597093,"date":"2016-12-28T15:45:11","date_gmt":"2016-12-28T15:45:11","guid":{"rendered":"https:\/\/wordpress.org\/support\/topic\/directory_separator-issue\/"},"modified":"2016-12-28T15:45:11","modified_gmt":"2016-12-28T15:45:11","slug":"directory_separator-issue","status":"publish","type":"topic","link":"https:\/\/wordpress.org\/support\/topic\/directory_separator-issue\/","title":{"rendered":"DIRECTORY_SEPARATOR Issue"},"content":{"rendered":"

Firstly, let me say I’m aware that this has been reported before<\/a> and that there’s a work-around. However, if the plug-in is upgraded or re-installed, then the work-around gets undone. Although not a show-stopper, it’s an annoyance.<\/p>\n

There are problems when the directory separator is \\<\/code> rather than \/<\/code>. To my knowledge, this is only Windows platforms, but as that’s a popular platform, I think this is important.<\/p>\n

#### Steps to reproduce:<\/p>\n

    \n
  1. Use a WordPress site running on a Windows host.<\/li>\n
  2. Install and activate “Snow Storm”.<\/li>\n
  3. Load a page.<\/li>\n
  4. Examine the source code.<\/li>\n<\/ol>\n

    #### Expected behaviour:<\/p>\n

      \n
    • The JavaScript file snow-storm.js<\/code> to be loaded, e.g.
      \n\t<script type='text\/javascript' src='\/wp-content\/plugins\/snow-storm\/snow-storm.js?ver=1.41'><\/script><\/code><\/li>\n
    • The snow effect to be rendered.<\/li>\n<\/ul>\n

      #### Actual behaviour:<\/p>\n

        \n
      • Incorrect script path specified, e.g.
        \n\t<script type='text\/javascript' src='\/wp-content\/pluginssnow-stormsnow-storm.js?ver=1.41'><\/script><\/code><\/li>\n
      • No snow effect.<\/li>\n<\/ul>\n

        #### Analysis:<\/p>\n

        File: snow-storm.php
        \nFunc: snow_storm_enqueue_scripts()
        \nLine: 116<\/p>\n

        \twp_enqueue_script('snow-storm', plugins_url() . DS . 'snow-storm' . DS . 'snow-storm.js', false, '1.41');<\/code><\/p>\n

        Due to the use of DS<\/code> i.e. DIRECTORY_SEPARATOR<\/code>, the resulting URL is:<\/p>\n

        \t\/wp-content\/plugins\\snow-storm\\snow-storm.js<\/code><\/p>\n

        This is causing problems later on in the processing, since the backslashes are not escaped, e.g.\\\\<\/code>. The result is that things like \\s<\/code> just end up as s<\/code>.<\/p>\n

        #### Recommendation:<\/p>\n

        As Windows supports the use of \/<\/code> as a path separator, at least those versions since command.com<\/code> was in use, then there’s no real need to use the DS<\/code> constant. It could be removed from the plug-in’s code, or at least permanently set to \/<\/code> rather than DIRECTORY_SEPARATOR<\/code>.<\/p>\n

        In any case, scripts should be specified as URLs when using <script src="..."><\/code>, not file system paths, so DS<\/code> should never have been used in this particular case.<\/p>\n

        I hope this is helpful.<\/p>\n","protected":false},"template":"","class_list":["post-8597093","topic","type-topic","status-publish","hentry"],"jetpack_sharing_enabled":true,"_links":{"self":[{"href":"https:\/\/wordpress.org\/support\/wp-json\/wp\/v2\/topic\/8597093","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/wordpress.org\/support\/wp-json\/wp\/v2\/topic"}],"about":[{"href":"https:\/\/wordpress.org\/support\/wp-json\/wp\/v2\/types\/topic"}],"version-history":[{"count":0,"href":"https:\/\/wordpress.org\/support\/wp-json\/wp\/v2\/topic\/8597093\/revisions"}],"wp:attachment":[{"href":"https:\/\/wordpress.org\/support\/wp-json\/wp\/v2\/media?parent=8597093"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}