Hi,<\/p>\n
I saw some additional shortcodes were started by the original author(s), but not finished. I finished and added some more. I believe this should allow users to correctly display confirmed users, unconfirmed users, a tally of each, and a total number of signatories all with shortcodes. I think the functions I called are fast and scoped to the minimum data, but let me know if you see any other optimizations. Below is an https:\/\/wordpress.org\/plugins\/lh-signing\/<\/p>\n","protected":false},"template":"","class_list":["post-7517194","topic","type-topic","status-publish","hentry"],"jetpack_sharing_enabled":true,"_links":{"self":[{"href":"https:\/\/wordpress.org\/support\/wp-json\/wp\/v2\/topic\/7517194","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/wordpress.org\/support\/wp-json\/wp\/v2\/topic"}],"about":[{"href":"https:\/\/wordpress.org\/support\/wp-json\/wp\/v2\/types\/topic"}],"version-history":[{"count":0,"href":"https:\/\/wordpress.org\/support\/wp-json\/wp\/v2\/topic\/7517194\/revisions"}],"wp:attachment":[{"href":"https:\/\/wordpress.org\/support\/wp-json\/wp\/v2\/media?parent=7517194"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}svn diff<\/code> to be applied as a patch:<\/p>\nIndex: lh-signing.php\n===================================================================\n--- lh-signing.php\t(revision 1443169)\n+++ lh-signing.php\t(working copy)\n@@ -656,8 +656,9 @@\n public function list_attached_users($id, $list, $fields) {\n\n $users = get_users( array(\n- 'connected_type' => array($list,'foobar'),\n- 'connected_items' => $id\n+ 'connected_type' => array($list),\n+ 'connected_items' => get_queried_object_id(),\n+ 'fields' => array($fields)\n ) );\n\n $return_string = "<ul>";\n@@ -664,7 +665,7 @@\n\n foreach ( $users as $user ) {\n\n-$return_string .= '<li>'.get_the_author_meta( 'display_name', $user->ID ).'<\/li>';\n+$return_string .= '<li>'. $user->{'display_name'} .'<\/li>';\n\n }\n\n@@ -674,7 +675,30 @@\n\n }\n\n+public function count_attached_users($id, $list, $fields) {\n\n+$users = get_users( array(\n+ 'connected_type' => array($list),\n+ 'connected_items' => get_queried_object_id(),\n+ 'fields' => array($fields)\n+) );\n+\n+\n+$user_count = 0;\n+\n+foreach ( $users as $user ) {\n+\n+$user_count++;\n+\n+}\n+\n+$return_string = $user_count;\n+\n+return $return_string;\n+\n+}\n+\n+\n public function the_content_filter( $content ) {\n\n global $post;\n@@ -910,6 +934,7 @@\n add_shortcode($this->namespace.'_form', array($this,"form_shortcode_output"));\n add_shortcode($this->namespace.'_unconfirmed_count', array($this,"unconfirmed_count_shortcode_output"));\n add_shortcode($this->namespace.'_confirmed_count', array($this,"confirmed_count_shortcode_output"));\n+add_shortcode($this->namespace.'_total_count', array($this,"total_count_shortcode_output"));\n add_shortcode($this->namespace.'_unconfirmed_list', array($this,"unconfirmed_list_shortcode_output"));\n add_shortcode($this->namespace.'_confirmed_list', array($this,"confirmed_list_shortcode_output"));\n\n@@ -961,10 +986,10 @@\n\n extract( shortcode_atts( array (\n 'id' => false,\n-'fields' => 'display_name' ), $atts )\n+'fields' => 'display_name' ), $atts )\n );\n\n-$return_string = $this_>list_attached_users($id, 'signing_sign_unconfirmed', $fields);\n+$return_string = $this->list_attached_users($id, 'signing_sign_unconfirmed', $fields);\n\n@@ -972,6 +997,66 @@\n\n }\n\n+public function confirmed_list_shortcode_output($atts,$content = null) {\n+\n+extract( shortcode_atts( array (\n+'id' => false,\n+'fields' => 'display_name' ), $atts )\n+);\n+\n+$return_string = $this->list_attached_users($id, 'signing_sign_confirmed', $fields);\n+\n+\n+\n+return $return_string;\n+\n+}\n+\n+\n+public function confirmed_count_shortcode_output($atts,$content = null) {\n+\n+extract( shortcode_atts( array (\n+'id' => false,\n+'fields' => 'display_name' ), $atts )\n+);\n+\n+$return_string = '<span class="confirmed_count">' . $this->count_attached_users($id, 'signing_sign_confirmed', $fields) . '<\/span>';\n+\n+\n+return $return_string;\n+\n+}\n+\n+public function unconfirmed_count_shortcode_output($atts,$content = null) {\n+\n+extract( shortcode_atts( array (\n+'id' => false,\n+'fields' => 'display_name' ), $atts )\n+);\n+\n+$return_string = '<span class="confirmed_count">' . $this->count_attached_users($id, 'signing_sign_unconfirmed', $fields) . '<\/span>';\n+\n+\n+return $return_string;\n+\n+}\n+\n+public function total_count_shortcode_output($atts,$content = null) {\n+\n+extract( shortcode_atts( array (\n+'id' => false,\n+'fields' => 'display_name' ), $atts )\n+);\n+\n+$return_string = '<span class="confirmed_count">';\n+$return_string .= $this->count_attached_users($id, 'signing_sign_unconfirmed', $fields) + $this->count_attached_users($id, 'signing_sign_confirmed', $fields);\n+$return_string .= '<\/span>';\n+\n+\n+return $return_string;\n+\n+}\n+\n public function add_meta_boxes($post_type, $post) {\n\n if (has_shortcode( $post->post_content, 'lh_signing_form' )){\n@@ -1576,4 +1661,4 @@\n\n-?>\n\\ No newline at end of file\n+?>\nIndex: readme.txt\n===================================================================\n--- readme.txt\t(revision 1443169)\n+++ readme.txt\t(working copy)\n@@ -16,6 +16,20 @@\n\n Creating a petition\/list\/signup is as easy as adding a shortcode to a post or page (or CPT). From there additional editors are available to configure easch aspect of the sign up. Everything is completely self hosted and all list members become users of your site (not a third parties).\n\n+Available shortcodes:\n+\n+[lh_signing_form] (enable signatories on any post, page, or custom post type)\n+\n+Unconfirmed signatories: [lh_signing_unconfirmed_count]\n+\n+Confirmed signatories: [lh_signing_confirmed_count]\n+\n+Total signatories: [lh_signing_total_count]\n+\n+[lh_signing_unconfirmed_list] (unformated list)\n+\n+[lh_signing_confirmed_list] (unformated list)\n+\n == Installation ==\n\n 1. Upload the <code>lh-signing<\/code> folder to the <code>\/wp-content\/plugins\/<\/code> directory\n@@ -97,4 +111,4 @@\n * Conditionally show admin boxes\n\n **2.61 June 22, 2016**\n-* Update links\n\\ No newline at end of file\n+* Update links<\/code><\/pre>\n