Plugin 1.4.0 \u00b7 ACF PRO 6.8.10 \u00b7 WordPress 7.1 Summary<\/p>\n\n\n\n
GREAT plugin, first off.<\/p>\n\n\n\n
With this plugin active, ACF’s flexible content field loses its collapsed-layout memory:
every layout renders expanded on each page load. Deactivating the plugin restores the
behavior immediately. The page I’m editing has ~56 flexible content layouts, so this is
the difference between a usable editor screen and an unusable one. Steps to reproduce<\/p>\n\n\n\n
Expected: layouts return collapsed.
Actual: every layout is expanded again. What I found<\/p>\n\n\n\n
ACF PRO stores flexible content collapse state in localStorage under the key “acf”, So if the same field asks for its state more than once in a single page load, the That is exactly what I see in localStorage with the plugin active:<\/p>\n\n\n\n One field, two entries. With the plugin deactivated, only the unsuffixed key appears js\/init.js attaches a MutationObserver to the entire document, unconditionally, whether Each batch re-arms a 250ms timer that calls update_tables() -> each_table(), which then I have not instrumented the double initialization directly; that part is inferred from Scope the observer rather than watching the whole document:<\/p>\n\n\n\n Happy to test a patch against the above setup.<\/p>\n","protected":false},"template":"","class_list":["post-19018559","topic","type-topic","status-publish","hentry","topic-tag-acf","topic-tag-collapse","topic-tag-flexible-content","topic-tag-localstorage"],"jetpack_sharing_enabled":true,"_links":{"self":[{"href":"https:\/\/wordpress.org\/support\/wp-json\/wp\/v2\/topic\/19018559","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/wordpress.org\/support\/wp-json\/wp\/v2\/topic"}],"about":[{"href":"https:\/\/wordpress.org\/support\/wp-json\/wp\/v2\/types\/topic"}],"version-history":[{"count":0,"href":"https:\/\/wordpress.org\/support\/wp-json\/wp\/v2\/topic\/19018559\/revisions"}],"wp:attachment":[{"href":"https:\/\/wordpress.org\/support\/wp-json\/wp\/v2\/media?parent=19018559"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}
as collapsedLayouts-<postID><\/code>, handled by the this.collapsedLayouts<\/code> model in
assets\/build\/js\/pro\/acf-pro-input.min.js. That model builds its storage key like this:<\/p>\n\n\n\nkey: function(key, context) { \/\/ context = \"load\" or \"save\"\n var count = this.get(key + context) || 0;\n count++;\n this.set(key + context, count, true);\n if (count > 1) key += '-' + count;\n return key;\n}<\/code><\/pre>\n\n\n\n
second request gets a DIFFERENT key with a “-2” suffix. Load and save keep separate
counters, so reads and writes can end up on opposite sides of that suffix.<\/p>\n\n\n\ncollapsedLayouts-1511: {\n field_610ac7050d4ff: Array(56),\n field_610ac7050d4ff-2: Array(55)\n}<\/code><\/pre>\n\n\n\n
and collapse state persists correctly. Suspected cause<\/p>\n\n\n\n
or not a Table field is present on the screen:<\/p>\n\n\n\nmutationObserver.observe( document.documentElement, {\n childList: true,\n subtree: true,\n});<\/code><\/pre>\n\n\n\n
mutates the DOM itself (adds classes, injects .acf-table-wrap) and so re-triggers its own
observer. On an ACF admin screen with a large flexible content field, that churn overlaps
the window in which ACF initializes the field, and the field ends up initialized more than
once \u2014 which mints the suffixed key above.<\/p>\n\n\n\n
ACF’s key-suffixing behavior plus the observed “-2” entry. What is directly confirmed is
that the “-2” key appears only while this plugin is active. Suggested fix<\/p>\n\n\n\n\n
.acf-table-root<\/code> exists on the page, or<\/li>\n\n\n\nappend<\/code> \/ ready<\/code> actions over a MutationObserver, which is how ACF
expects add-ons to learn about new fields, and<\/li>\n\n\n\n
ACF_TABLEFIELD_FILTER_POSTMETA.<\/li>\n<\/ul>\n\n\n\n