{"id":1778720,"date":"2010-11-20T19:33:45","date_gmt":"2010-11-20T19:33:45","guid":{"rendered":"https:\/\/wordpress.org\/support\/topic\/sharedaddy-code-improvements\/"},"modified":"2016-08-19T20:43:53","modified_gmt":"2016-08-19T20:43:53","slug":"sharedaddy-code-improvements","status":"closed","type":"topic","link":"https:\/\/wordpress.org\/support\/topic\/sharedaddy-code-improvements\/","title":{"rendered":"Sharedaddy code improvements"},"content":{"rendered":"<p>I made a <a href=\"https:\/\/plugins.trac.wordpress.org\/ticket\/1240\">patch<\/a> with some improvements:<\/p>\n<ul>\n<li>i18n of services&#8217; names<\/li>\n<li>filters for services&#8217; names in links<\/li>\n<li>missing textdomain from gettext function<\/li>\n<li>filter for exclusion of custom post types<\/li>\n<\/ul>\n<p>Filters for names of services are added because of languages that use cases, where just translation of service&#8217;s name is not enough. <\/p>\n<p>For example, in Serbian we can have <em>\u041f\u043e\u0434\u0435\u043b\u0438 \u043e\u0432\u043e: \u0424\u0435\u0458\u0441\u0431\u0443\u043a<\/em> for <em>Share this: Facebook<\/em>, but we&#8217;ll have <em>\u041f\u043e\u0434\u0435\u043b\u0438 \u043e\u0432\u043e \u043d\u0430: \u0424\u0435\u0458\u0441\u0431\u0443\u043a\u0443<\/em> for <em>Share this on: Facebook<\/em>.<\/p>\n<p>Filter for post types is added because Sharedaddy uses is_single function so if posts are chosen as option, it adds sharing on all post types except pages.<\/p>\n<p>Note that we still won&#8217;t have post meta box for exclusion since post types are not supported well (it&#8217;s wpcom centric plugin).<\/p>\n<p>Please include updated POT file in next release.<\/p>\n","protected":false},"template":"","class_list":["post-1778720","topic","type-topic","status-closed","hentry"],"jetpack_sharing_enabled":true,"_links":{"self":[{"href":"https:\/\/wordpress.org\/support\/wp-json\/wp\/v2\/topic\/1778720","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/wordpress.org\/support\/wp-json\/wp\/v2\/topic"}],"about":[{"href":"https:\/\/wordpress.org\/support\/wp-json\/wp\/v2\/types\/topic"}],"version-history":[{"count":0,"href":"https:\/\/wordpress.org\/support\/wp-json\/wp\/v2\/topic\/1778720\/revisions"}],"wp:attachment":[{"href":"https:\/\/wordpress.org\/support\/wp-json\/wp\/v2\/media?parent=1778720"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}