First of all: interesting plug-in and very useful for many people, I think. It should have much more attention (and downloads).<\/p>\n
Anyway, I’m testing the search function and have a few comments, which may be some improvements. I’ve made some modifications to the wibergsweb.js file, but let me make clear that I’m not an expert in javascript.<\/p>\n
The thing is that if you click on ‘Reset’ the full table displays, although I’ve set hidetable_load to “yes”. Therefor, I’ve added one line after line 35, so they now look like this:<\/p>\n
\ntablewrapper_obj[0].outerHTML = response.tabledata;\n$('tr').hide();\n<\/code><\/pre>\nIf you now click on ‘Reset’ the table disappears. Maybe it’s even enough to just comment that line with ‘tablewrapper_obj’, possibly with an ‘if’ statement that checks whether you want a clean page on pageload?<\/p>\n
Another thing is that a click on ‘Search’ with nothing filled in the searchbox also displays the full table. Not ideal. To check whether there’s a value in the search box (and what the length is), I’ve included an ‘if’ statement after line 65. It looks like this:<\/p>\n
\n var search_text = $(this).parent().find('.search-text').val(); \n\t\tif (search_text.length < 5) { \n\t\t\talert('Please enter a minimumn of 5 characters');\n\t\t\treturn false;\n\t\t}\n var h = $(this).data();\n<\/code><\/pre>\nThis checks if the search string is at least 5 characters, otherwise it will display an alert and abort the function. Can be any length of course. I suppose it could be further adjusted by checking for numbers only or letters only.<\/p>\n
And lastly, there’s a thing I couldn’t find a solution for. If you search for anything that you are sure is not in the table, the ‘result’ is again the full table display. That’s of course not how search should be working. There should be a “Sorry, didn’t find anything” message. But apart from that I’m wondering why there even is a ‘result’, it should return nothing. Has this to do with what seems to be a ‘wildcard’ function in search?<\/p>\n
Again, a very good plug-in and I hope you keep up the good work!<\/p>\n","protected":false},"template":"","class_list":["post-14584259","topic","type-topic","status-publish","hentry","topic-tag-csv","topic-tag-tables"],"jetpack_sharing_enabled":true,"_links":{"self":[{"href":"https:\/\/wordpress.org\/support\/wp-json\/wp\/v2\/topic\/14584259","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/wordpress.org\/support\/wp-json\/wp\/v2\/topic"}],"about":[{"href":"https:\/\/wordpress.org\/support\/wp-json\/wp\/v2\/types\/topic"}],"version-history":[{"count":0,"href":"https:\/\/wordpress.org\/support\/wp-json\/wp\/v2\/topic\/14584259\/revisions"}],"wp:attachment":[{"href":"https:\/\/wordpress.org\/support\/wp-json\/wp\/v2\/media?parent=14584259"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}