{"id":14273712,"date":"2021-04-04T01:22:56","date_gmt":"2021-04-04T01:22:56","guid":{"rendered":"https:\/\/wordpress.org\/support\/topic\/unescaped-javascript-string\/"},"modified":"2021-04-04T01:22:56","modified_gmt":"2021-04-04T01:22:56","slug":"unescaped-javascript-string","status":"publish","type":"topic","link":"https:\/\/wordpress.org\/support\/topic\/unescaped-javascript-string\/","title":{"rendered":"unescaped javascript string"},"content":{"rendered":"

While using developer tools on a web page, I noticed the following javascript…<\/p>\n

Uncaught SyntaxError: "" string literal contains an unescaped line break<\/code><\/p>\n

This error was being caused by the line starting with text: ” in the following script generated by your plugin…<\/p>\n

<script>\n\twindow.addEventListener("DOMContentLoaded", function(){\n\t\tif ( navigator.share ) {\n\t\t\t\t\t\t\tlet shareurl = document.location.href;\n\t\t\tlet btns = document.querySelectorAll(".juiz_sps_link_shareapi button:not([data-bound])");\n\t\t\tconst canon = document.querySelector("link[rel=canonical]");\n\n\t\t\tif (canon !== null) {\n\t\t\t\tshareurl = canon.href;\n\t\t\t}\n\n\t\t\tbtns.forEach(function(el) {\n\t\t\t\t\t\t\t\tel.closest(".juiz_sps_link_shareapi").removeAttribute( "style" );\n\t\t\t\tel.setAttribute( "data-bound", "true" );\n\t\t\t\t\t\t\t\tel.addEventListener("click", async () => {\n\t\t\t\t\ttry {\n\t\t\t\t\t\tawait navigator.share({\n\t\t\t\t\t\t\t\t\t\t\ttitle: "How To Protect WordPress with CloudFlare Firewall Rules",\n\t\t\t\t\t\t\t\t\t\t\ttext: "How To Protect WordPress with CloudFlare Firewall Rules - OVERVIEW\nCloudFlare recently added Firewall Rules to all accounts, including",\n\t\t\t\t\t\t\t\t\t\t\turl: shareurl,\n\t\t\t\t\t\t});\n\t\t\t\t\t\t\t\t\t\tconsole.info("Successful share");\n\t\t\t\t\t} catch(err) {\n\t\t\t\t\t\t\t\t\t\tconsole.warn("Error sharing", error);\n\t\t\t\t\t}\n\t\t\t\t});\n\t\t\t});\n\t\t}\n\t});\n<\/script><\/code><\/pre>\n
It looks like you could use some esc_js() calls on your javascript string outputs.<\/p>\n
Thanks.<\/p>\n","protected":false},"template":"","class_list":["post-14273712","topic","type-topic","status-publish","hentry","topic-tag-javascript"],"jetpack_sharing_enabled":true,"_links":{"self":[{"href":"https:\/\/wordpress.org\/support\/wp-json\/wp\/v2\/topic\/14273712","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/wordpress.org\/support\/wp-json\/wp\/v2\/topic"}],"about":[{"href":"https:\/\/wordpress.org\/support\/wp-json\/wp\/v2\/types\/topic"}],"version-history":[{"count":0,"href":"https:\/\/wordpress.org\/support\/wp-json\/wp\/v2\/topic\/14273712\/revisions"}],"wp:attachment":[{"href":"https:\/\/wordpress.org\/support\/wp-json\/wp\/v2\/media?parent=14273712"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}