simonetel

Forum Replies Created

Viewing 2 replies - 1 through 2 (of 2 total)
  • Forum: Plugins
    In reply to: [Simple Social Media Share Buttons - Social Sharing for Everyone] SSB breaks the page if it contains an explicit excerpt
    Thread Starter simonetel

    (@simonetel)

    5 years, 1 month ago

    here’s an example:

    
Con grande soddisfazione comunichiamo che RCS MediaGroup ha scelto <strong>Exelis <a href="https://www.exelis.it/prodotti-servizi/lilium/" target="_blank" rel="noopener">Lilium</a></strong> per gestire i processi di acquisizione della pubblicità classificata e delle necrologie.
Lilium è la piattaforma web che nasce dall’esperienza maturata dalla nostra azienda nel supporto di tutti flussi di lavorazione necessari ad acquisire, comporre e valorizzare i contenuti tipicamente raccolti dallo “sportello” delle concessionarie.

    Since you just add this text to the description, you’re bound to create broken code:

    
<meta property="og:description" content="Con grande soddisfazione comunichiamo che RCS MediaGroup ha scelto <strong>Exelis <a href="https://www.exelis.it/prodotti-servizi/lilium/" target="_blank" rel="noopener">Lilium</a></strong> per gestire i processi di acquisizione della pubblicità classificata e delle necrologie.
Lilium è la piattaforma web che nasce dall’esperienza maturata dalla nostra azienda nel supporto di tutti flussi di lavorazione necessari ad acquisire, comporre e valorizzare i contenuti tipicamente raccolti dallo “sportello” delle concessionarie." />

    (quotes are unbalanced and tags should not appear there)

    get_excerpt_by_id() in your code only strip tags if has_excerpt() is false. In both cases, I’d add esc_html() just to be on the safe side, anyway.

    • This reply was modified 5 years, 1 month ago by simonetel.
    • This reply was modified 5 years, 1 month ago by simonetel.
    Forum: Plugins
    In reply to: [AccessPress Social Login Lite - Social Login WordPress Plugin] A couple of suggestions
    Thread Starter simonetel

    (@simonetel)

    8 years, 8 months ago

    thanks for the update.

    The site I’m working on is not live yet, so I can’t point you to it at the moment.

    Let’s see if I can explain it better: I’m placing the plugin shortcode inside a page (I mean a WordPress “Page”). That page is loaded via a fancybox iframe (just like the iframe example at the bottom of http://fancybox.net/).

    In this scenario there are several problems:

    1. you cannot login from a frame. You’ll get this error, for instance:
      Refused to display 'https://www.facebook.com/login.php?skip_api_login=1&api_key=...' in a frame because it set 'X-Frame-Options' to 'DENY'.
    2. anyway, after logging in, the top frame should be reloaded, not only the iframe in the fancybox. So adding a target=”_top” to the login buttons is required and I can’t see any case where that would cause problems.
    3. since the shortcode is contained in a page, the line
      $current_url = APSL_Lite_Login_Check_Class::curPageURL();
      in shortcode.php is basically useless. $current_url will always be the URL of the login page, but the real return url is an argument to that page. I send users to the login page with a link like this:
      /login-popup?redirect=%2Fmy_return_page
      That’s why in my previous suggestion I was checking $_GET[ ‘redirect’ ]. The name of the argument (redirect) is the one that’s used by another plugin I’m using in the login page (Restrict Content Pro). If both plugins used the same name it would be cool, but I guess I could add a new argument if you really don’t like it 🙂

    I hope this clarifies some things

Viewing 2 replies - 1 through 2 (of 2 total)