rayfusci
Forum Replies Created
-
Thank you. Please let us know what they say.
Yes, it was. (And is. The file is now present on my server in both forms. You can use your string above to access it with a web browser.) The apostrophe is a valid character in a filename (even on Windows). I didn’t add an apostrophe to the filename, the filename had an apostrophe in it, as it is partly a person’s name. My web browsers (Firefox and Chrome) have no problem with that URL. Chrome didn’t escape the apostrophe, although it did escape the spaces.
If you want to further restrict what filename characters are acceptable to your plugin, you really ought to document it. Or you could validate the argument and escape any problematic characters.
Sure. With apostrophe:
[sc_embed_player fileurl="http://www.onlyinbridgeport.com/wordpress/audio/Gene O'Neill 09-03-25.mp3"]Fails. The player icon is not clickable.
Without apostrophe (and I also renamed the file):
[sc_embed_player fileurl="http://www.onlyinbridgeport.com/wordpress/audio/Gene ONeill 09-03-25.mp3"]Works just fine.
Forum: Plugins
In reply to: [Custom Meta Widget] Make Title Optional… I originally put in
for a title, …Forum: Plugins
In reply to: [Custom Meta Widget] Make Title OptionalI’m using version 1.5.1 of the plugin, which appears to be the latest available.
I tried to send this same request to the support address, but the email bounced
----- The following addresses had permanent fatal errors ----- <plugins@shinraholdings.com> (reason: 550 5.1.1 <plugins@shinraholdings.com> Recipient not found. <http://x.co/irbounce>)Luke, I hope nothing serious is wrong!
Here’s what I tried to send via email:
============
Thank you for writing this widget!I think it would be useful to others to be able to suppress the Title line.
You could potentially add a checkbox for this.
For my purposes, I commented out the line in the plugin where you set a
default title if the title was empty. Then when the title is empty, it
doesn’t output the Title line at all.I originally put in for a title, which does suppress the title text,
but still outputs a blank line.best regards,
============In case someone else wants to make the same edit I did while we’re waiting for the new feature, comment out this line:
/* $title = ! empty( $instance['title'] ) ? $instance['title'] : __( 'Meta', 'customMetaWidget' ); */Forum: Plugins
In reply to: [WP-Polls] Can't delete logs for some pollsHi Lester,
Actually, you didn’t use esc_js on that string. Your use of esc_js just missed it. (I had to stare at it and count parens several times before I saw it.)So if I wrap htmlspecialchars($poll_question) with esc_js, it works.
Hope this saves you some time.
Best regards,
Forum: Plugins
In reply to: [WP-Polls] Can't delete logs for some pollsHi Lester,
Thanks to your hints about how things work, I’ve found the bug. It’s in polls-logs.php.It never makes the AJAX call. It never prints the “You are about to delete…” message in polls-logs.php.
The thing all the polls that failed have in common is the poll question has an apostrophe character in it, and all the polls that succeeded did not. The “You are about to delete…” message prints out the poll question, and the apostrophe character is getting seen and causing that statement to crash, therefore the AJAX call is not made.
When I changed a failing poll question to remove the apostrophe, the logs delete normally.
Forum: Plugins
In reply to: [WP-Polls] Can't delete logs for some pollsHi Lester, thank you for replying so quickly.
The log records for those six polls are still there. Here is a specific example:
In your plugin, I can see 90 log records for poll 13.
When I go into phpMyAdmin and do this inquiry:
SELECT * FROM wp_pollsip WHERE pollip_qid = 13I get those same 90 records. As a test, I deleted the first record of this collection in phpMyAdmin. It deleted just fine from there.
I then go back to your plugin, and I now see (as expected) 89 log records for poll 13. I still can’t delete them from here, though.
Please note the failure occurs before we even get to your delete code. Your message “You are about to delete poll logs for this poll ONLY…” does not appear like it did for the other 18 polls where I was able to delete the logs.
I am capable of inserting debugging code into your plugin for you if you think that would be useful.
Forum: Plugins
In reply to: [WP-Polls] Bug – Shows 100% on last option if no votesForum: Plugins
In reply to: [WP-Polls] Bug – Shows 100% on last option if no votesWP-Polls 2.67
WordPress 3.9.1
I’m seeing the same thing on my site.
Since the example at Lester Chan’s link above actually does indeed reproduce the “problem” when I click on “View Results”, you shouldn’t need a link to anywhere else.jimmygle, the consequence of taking out that code is you could have a poll where if you add the results, you won’t get 100%. Say the poll percentages were 11.33, 33.33 and 55.34. With that code, the results will read 11%, 33% and 56%, total of 100%. Without that code, the results will read 11%, 33% and 55%, total of 99%. Personally, I think the code should be removed, as I believe even though the results don’t add to 100%, the results are more accurate, but then you’ll have people complaining the results don’t add to 100%. Many commercial polls will sometimes add a disclaimer saying the results don’t add to 100% because of round-off, other polls don’t bother.
I had the same error when I upgraded to 3.0.
If you look at the changelog for the 3.0.1 update, the last bugfix mentioned sounds like it could be this issue.
I just installed the update, hopefully this fixes it. I’ll be back tomorrow if it doesn’t.
If you want to see the exact shortcode I used, look at my original post about the problem above; but yes, I set ‘playlistfile’.
I tried setting ‘file’ instead and it now works with the latest version.
Seeing as ‘playlistfile’ used to work, is using ‘file’ a workaround, or was I just lucky ‘playlistfile’ ever worked and I always should have been using ‘file’?
But regardless, thank you very much, I appreciate it.
I did some more version testing, and I found 1.5.5 works, but 1.5.6 does not. Hopefully this will allow you to narrow down where to look for the problem.
I just noticed v1.5.9 is available.
I’m unhappy to report this version did not fix the problem.
Please refer to the same two links above to see the problem. The second link referring to 1.5.8 has been updated to 1.5.9.
Thank you, I’ll try it when it comes out and report back here.
Any plan as to when you’ll be releasing the fix?