Michael Finkenberger
Forum Replies Created
-
Remark:
The “waiting” is an almost invisible progress bar, which I changed in appearance by CSS.
In the same way I modified (cancelled) the word-wrap in the file-list-mode once columns are small…
However, the 50 files bug is still annoying…
Best regards
Michael
Dear @modalweb,
with a number of in-between updates, the described error disappeared – at least for the time being.
However, your plugin is still interfering with a plugin called “Ditty News Ticker”.
When your shortcode is active, a jQuery-function of Ditty is no longer considered as defined.
You will find a sample page with your plugin shortcode deactivated and another one with your plugin shortcode activated.
The news ticker will only work, if your shortcode is not active. You will see the related function error in the browser’s source code window.
Best regards
Michael
- This reply was modified 5 years, 4 months ago by Michael Finkenberger.
- This reply was modified 5 years, 4 months ago by Michael Finkenberger.
I would love to but this is restricted space…
Therefore, I have generated two pages, one with the file manager shortcode inactive and one with the file manager shortcode active.
Best regards
Michael
- This reply was modified 5 years, 4 months ago by Michael Finkenberger.
Hi @modalweb,
thanks for the update!
Yeah, the theme issue feels resolved! Great!
So, what’s still different compared to before:
– when e.g. opening a folder, before, until done, there was a kind of “waiting” indication, which is still not showing (in my site context).
This is a bit troublesome as one has to wait without indication whether an action is going to be accomplished or not.And, what’s still not quite correct:
– Sometimes, especially when opening the first time after a while, folders with more than 50 files will only show the first 50 files.
Only after switching back and forth to list and then back to grid mode, all files will be shown.This is just for you to know – the plugin is awesome anyway!
Best regards
Michael
By the way:
The grey theme works in the admin area, but not in the front-end.
Best regards
Michael
with your latest update, the Popup Maker popups are indeed no longer blocked, when both, WP Photo Album Plus and Ditty New Ticker are active. Thanks a lot!
However, Ditty News Ticker is still blocked, when „File Manager Advanced“ is activated and invisible, when WP Photo Album Plus is de-activated (my sidebar through „AMR Shortcode Any Widget“ still likewise).
By the way, jQuery Migrate reports that
– jQuery.fn.mousedown() event shorthand is deprecated in /wp-content/plugins/ditty-news-ticker/inc/static/libs/qTip2/jquery.qtip.min.js
and
– jQuery.type is deprecated in /wp-content/plugins/ditty-news-ticker/inc/static/libs/qTip2/jquery.qtip.min.js
but these were the messages you probably saw anyway and there are even a few more…@danieliser:
By the way, jQuery Migrate reports that jQuery.type is deprecated in /wp-content/plugins/popup-maker/assets/js/admin-marketing.min.js…Best regards
Michael
- This reply was modified 5 years, 5 months ago by Michael Finkenberger.
- This reply was modified 5 years, 5 months ago by Michael Finkenberger.
- This reply was modified 5 years, 5 months ago by Michael Finkenberger.
- This reply was modified 5 years, 5 months ago by Michael Finkenberger.
- This reply was modified 5 years, 5 months ago by Michael Finkenberger.
Dear all,
after contacting Ditty News ticker, @metaphorcreations will post his findings here.
However, things are getting weird after the recent update of both, WP Photo Album plus and Popup Maker (and “File Manager Advanced”).
Independent of “File Manager Advanced” (activated or de-activated), the issue persists, but now, with WP Photo Album Plus de-activated, Ditty News Ticker will disappear…, as well as my sidebar (“AMR Shortcode Any Widget”). I.e. WP Album Photo Plus needs to stay activated…
And this latter behavior is independent from the jQuery version activated!“File Manager Advanced” will break Ditty News Ticker, but this is a different story, not to be treated here, since independent from the rest…
All my postings here a just meant to help you in finding out, where to dig.
Best regards
Michael
- This reply was modified 5 years, 5 months ago by Michael Finkenberger.
Dear @opajaap,
your might want to check my latest findings above…
For Popup-Maker, you could go to its admin page to add triggers and use e.g. their classname as a trigger.
Typically, there is as well a function to collect a selector in the admin header’s Popup Maker menu on the frontend.Best regards
Michael
@danieliser – Maybe I don’t understand correctly, but I did this test today several times.
As I see the effect in PM only, these are the combinations tested:
WP Photo + PM: OK
Ditty + PM: OK
WP Photo + Ditty + PM: NoGoIs there something missing?
Best regards
Michael
Dear @opajaap and @danieliser,
as I stated earlier, due to the alphabet, WP Photo Album Plus was one of the last plugins to switch on again, so I noticed that with WP Photo Album Plus, the issue with Plugin Maker appeared.
However, in another site, I just made a test and found out that WP Photo Album Plus and Plugin Maker work fine together, even in latest WordPress 5.6 jQuery Version. So the question was: which other plugin might interfere with both.
With deactivating – one by one – those plugins not present in the functioning set-up, I could identify “Ditty News Ticker” (Metaphor Creations) to be part of the interference issue.
With either Ditty or WP Photo active, Plugin Maker works. With both active, it doesn’t…
It is getting a bit complex, but I cannot tell you a better message…
So the question is: are you still interested to solve such an 3-partite interference or shall I just look for another Newsticker?
I will raise this in front of Ditty News Ticker, but I doubt it will be easy to determine without your participation.
Best regards
Michael
Hi @opajaap and @danieliser,
first of all: THANKS for your extraordinary engagement and enthusiasm!
Well, I checked version 7.6.03.003 – unfortunately without success.
As soon as I switch jQuery Migrate Helper to the current WordPress jQuery, the popups won’t load.
Switching back to the “old” Legacy 1.12.4-wp jQuery version makes them appear again.
Deactivating WP Photo Album Plus will do the same…I cannot tell, witch events I am using behind the scenes, as I am using Popup Maker to trigger on certain classes being pressed.
I am really sorry that I am not of real help…
Best regards
Michael
- This reply was modified 5 years, 5 months ago by Michael Finkenberger.
- This reply was modified 5 years, 5 months ago by Michael Finkenberger.
Great!
Dear @opajaap,
following your kind input, please see here below the response received from Daniel Iser (@danieliser), plugin author of “Popup Maker”.
Perhaps, this can help to isolate the interference.
Best regards
Michael
——————————————————————————-
@mitfi – Unfortunately I wouldn’t have the feintest clue where to start with debugging why their plugin is causing issues.
I do see they made some changes a week or so ago for WP 5.6 compatibility, though I couldn’t find exactly what those were.
It should also be noted that we can’t/shouldn’t be expected to go line by line in their plugin looking for the cause if I’m being honest. We have 600k users to support for our own code. And there is a small portion of those users, yourself included, currently saying our popups aren’t working with the latest version, most are finding, as you did, causes from 3rd party products. If we took the time to debug all of these 3rd party products code ourselves we would never be able to keep up, much less advance our own code.
Now what we can and should do in these cases is attempt to narrow where the issue is coming from, and attempt to limit the scope of the other authors search. For example if we can point to a specific theme JS file or even specific function in that file it greatly improves the chances.
I haven’t seen your site specifically though to be able to comment, but if you went through my previous post with the troubleshooting steps and found nothing of note you may need to just open a support ticket with us and them and try to get them to work with us to resolve it.
That said I do see stuff in there code that won’t work in general, might be worth pointing those things out in the mean time. For example this line was added 9 days ago, but jQuery .off doesn’t work with anonymous functions, so the old version of this code was better. As it is this code likely does nothing, and since they are immediately doing a .on attaching that function again, its likely going to cause it to duplicate the render call repeatedly.
‘$(window).off(“fullscreenchange mozfullscreenchange webkitfullscreenchange msfullscreenchange”,function(){abort=true;setTimeout(function(){abort=false;render();},1000)});’ .
Dear Jeff,
that’s great news.
I like your plugin a lot and I am aware that this is not a current problem but may become a future one.
Thanks a lot for providing good and useful tools for our community!
Best regards and take care
Michael
Yes they do, as there’s no other tool installed that will do the job to identify deprecated code.