jorgeorpinel
Forum Replies Created
-
Forum: Plugins
In reply to: [Acunetix WP Security] Your plugin has known vulnerabilities.So I guess you’re not very concerned with security vulnerabilities in your security plugin. That’s not a great sign…
Forum: Plugins
In reply to: [Login Lockdown - Protect Login Form] Multisite Compatibility?Just commenting here to get subscribed to the topic. Would like to see this implemented. Cheers
Forum: Plugins
In reply to: [Search Everything] Notice: trying to get property of non-objectJust bumped into the bug. Looking forward to this being fixed. Please let us know 🙂
I added
mla_rollover_text="{+description+}"
to my shortcode but it didn’t solve my issue. I removedtitle="[+description+]"
from my mla_markup which of course fixes it but I’m missing the tooltip now now.Another option is to make sure the attachment description doesn’t have double quotes but if you think it’s important enough, I hope you can patch this when possible.
On that note, where do you keep the complete docs for the plugin? If somewhere. Is there a place I can read a reference of all the different options, shortcodes, and their parameters?
Thanks!
Ah sorry my mla-markup is
Open:
<div id='[+selector+]' class='gallery galleryid-[+id+] gallery-columns-[+columns+] gallery-size-[+size_class+]'>
Item:
<[+itemtag+] class='gallery-item'> <[+icontag+] class='gallery-icon'> <a href="[+filelink_url+]" title="[+description+]" class="colorbox-vws"> [+thumbnail_content+] <div style="position: absolute;">[+caption+]</div> </a> </[+icontag+]> <[+captiontag+] class='wp-caption-text gallery-caption'> [+caption+] </[+captiontag+]> </[+itemtag+]>
Row Close:
<br style="clear: both" />
That’s it. It seems you already have a diagnostic though. I will try what you suggest and report back ASAP.
Hi David,
1. That was the actual value in the description. Thanks for noticing. I fixed the URL but I’m having the same problem. I think Chrome dev tools auto fixed the link in the image before. Let me paste the actual source from “view source” in the browser:
<dt class='gallery-icon'> <a href="http://skyscraper.org/cms/wp-content/uploads/2011/06/1941-26WS-HABS-plans-cover-sheet-LOC.jpg" title="U.S. Customs House plans from the 1941 Historic American Buildings Survey (HABS). Background: The building was originally designed as a custom house for the City of New York and was used as such until about 1860, when it was taken over as the United States Sub-Treasury. The Historic American Buildings Survey (HABS) has been administered since 1933 to record America’s built environment in multiformat surveys comprising measured drawings, large-format photographs, and written histories for historic structures and sites dating from Pre-Columbian times to the twentieth century. For the full set of plans and additional images see the <a href="http://www.loc.gov/pictures/search/?q=Drawing%3A+ny0363&fi=number&op=PHRASE&va=exact"> Library of Congress site </a>" class="colorbox-vws"> <img width="300" height="300" src="http://skyscraper.org/cms/wp-content/uploads/2011/06/1941-26WS-HABS-plans-cover-sheet-LOC-300x300.jpg" class="attachment-vws" alt="1941 26 WS HABS plans cover sheet LOC" /> <div style="position: absolute;"></div> </a> </dt>
It seems to me the href quote in the description breaks the output of mla-gallery so
" class="colorbox-vws">
ends up being spitted independently.2. Is it my vws markup? I reviewed it and didn’t find a problem but I may be wrong. Here it is:
<style type='text/css'> #[+selector+] { margin: auto; width: 100%; } #[+selector+] .gallery-item { float: [+float+]; /*margin: [+margin+]%;*/ text-align: center; width: 300px; height: 300px; overflow: hidden; } #[+selector+] .gallery-item .gallery-icon img { /*border: none;*/ } #[+selector+] .gallery-caption { margin-left: 0; vertical-align: top; } </style> <!-- see mla_gallery_shortcode() in media-library-assistant/includes/class-mla-shortcodes.php -->
3. Yesh its a 300px by 300px center-cropped thumbnail size I registered.
4. The description is indeed ending up in the title attribute of but I didn’t know I can control that. I thought it’s just part of how mla-gallery renders it. I implemented the shortcode some time agoa dn may not remember all the settings and options, sorry.
No rush at all, thanks for taking a look.
Forum: Plugins
In reply to: [Collapse-O-Matic] Line break problemThat was
[/expand]
😛Forum: Plugins
In reply to: [Collapse-O-Matic] Line break problemOk. [/expand] does the job for me.
Yeah, dang wpautop is buggy.
Forum: Plugins
In reply to: [Collapse-O-Matic] Line break problemHmmm, this may have some hack-fix options: http://wordpress.org/support/topic/plugin-jquery-collapse-o-matic-space-after-first-title?replies=16
Forum: Plugins
In reply to: [Category Icons] Missing Argument 2 for wpdb::preparep.s. Actually that last message may be a problem in another plugin, https://wordpress.org/plugins/wordfence/ , which is reporting the SQL error. This wouldn’t be unlike what’s described over at http://wordpress.org/support/topic/fatal-error-site-down
Forum: Plugins
In reply to: [Category Icons] Missing Argument 2 for wpdb::prepareI still get a notice with the file at pastebin.com/XevRdaZg:
Notice: wpdb::prepare was called incorrectly. The query argument of wpdb::prepare() must have a placeholder. Please see Debugging in WordPress for more information. (This message was added in version 3.9.) in …/wp-includes/functions.php on line 3245
Which is solved by changing category_icons.php:1047 to
$wpdb->query(“CREATE TABLE IF NOT EXISTS
$wpdb->ig_caticons
(cat_id
INT NOT NULL ,priority
INT NOT NULL ,icon
TEXT NOT NULL ,small_icon
TEXT NOT NULL , PRIMARY KEY (cat_id
))”);Note: there’s backquotes/backticks (stripped out by wordpress.org) around all literals = $wpdb->ig_caticons, cat_id, priority, icon, small_icon, and cat_id (again)
However I still have a recurrent SQL error which I’m unable to locate/fix:
WordPress database error: [You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ”cms_ig_caticons” at line 1]
select count(*) from ‘cms_ig_caticons’
0(I’m guessing that 0 is the culprit.)
Forum: Fixing WordPress
In reply to: What happens exactly during the plugin update process?Thank you and sorry for the late reply.
The scripts seem like a good option. I’m also considering emulating the wordpresss.org plugin update service on my own servers and enable automatic background plugin updates but sounds a bit complicated to achieve. Lastly I’m considering making a special mu-plugin that fires upgrader_process_complete every time files are changed but not sure if that’s possible to do.
To tell you the truth it doesn’t seem like that big a deal, I’ve been sync’ing via git for a while and I don’t think anything has broken for not using the normal plugin update process. But if any one has any more ideas please share them.
Cheers
Forum: Fixing WordPress
In reply to: What happens exactly during the plugin update process?Can I ask why you need to know?
I’m trying to figure out how to automate plugin updates for many sites from a single place, for example using git. I just want to make sure that “manual” updates (not involving clicking “update” in wp-admin) are reliable. It seems, for example, that with a manual update, the upgrader_process_complete action would not fire so any plugin relying in that may run into problems.
My other idea is to build a tool that uses wp-cli but source control would be ideal.
Forum: Fixing WordPress
In reply to: What happens exactly during the plugin update process?p.s. this is the only action I can see that relates to the plugin update process: upgrader_process_complete. I wonder if anyone actually uses it and if it fires inside the same plugin that has been installed or updated.
Forum: Fixing WordPress
In reply to: What happens exactly during the plugin update process?Thanks @esmi.
I have looked at the Settings API, but not it extensively used it (only the Options API). I’m looking into its documentation and I don’t see how it could impact a plugin update.
I wish WordPress had more info regarding what happens during a plugin update but I guess its safe to assume those 4 steps are pretty much it. If anyone knows of actions or filters, etc that are also involved please let me know!