Title: codejp3's Replies - page 23 | WordPress.org

---

# codejp3

  [  ](https://wordpress.org/support/users/codejp3/)

 *   [Profile](https://wordpress.org/support/users/codejp3/)
 *   [Topics Started](https://wordpress.org/support/users/codejp3/topics/)
 *   [Replies Created](https://wordpress.org/support/users/codejp3/replies/)
 *   [Reviews Written](https://wordpress.org/support/users/codejp3/reviews/)
 *   [Topics Replied To](https://wordpress.org/support/users/codejp3/replied-to/)
 *   [Engagements](https://wordpress.org/support/users/codejp3/engagements/)
 *   [Favorites](https://wordpress.org/support/users/codejp3/favorites/)

 Search replies:

## Forum Replies Created

Viewing 15 replies - 331 through 345 (of 407 total)

[←](https://wordpress.org/support/users/codejp3/replies/page/22/?output_format=md)
[1](https://wordpress.org/support/users/codejp3/replies/?output_format=md) [2](https://wordpress.org/support/users/codejp3/replies/page/2/?output_format=md)
[3](https://wordpress.org/support/users/codejp3/replies/page/3/?output_format=md)…
[22](https://wordpress.org/support/users/codejp3/replies/page/22/?output_format=md)
23 [24](https://wordpress.org/support/users/codejp3/replies/page/24/?output_format=md)…
[26](https://wordpress.org/support/users/codejp3/replies/page/26/?output_format=md)
[27](https://wordpress.org/support/users/codejp3/replies/page/27/?output_format=md)
[28](https://wordpress.org/support/users/codejp3/replies/page/28/?output_format=md)
[→](https://wordpress.org/support/users/codejp3/replies/page/24/?output_format=md)

 *   Forum: [Plugins](https://wordpress.org/support/forum/plugins-and-hacks/)
    In
   reply to: [[bbp style pack] Was it always like this?](https://wordpress.org/support/topic/was-it-always-like-this/)
 *  [codejp3](https://wordpress.org/support/users/codejp3/)
 * (@codejp3)
 * [3 years, 4 months ago](https://wordpress.org/support/topic/was-it-always-like-this/#post-16442333)
 * [@robin-w](https://wordpress.org/support/users/robin-w/) – This is patched. I
   couldn’t find any changes related the image alignment. In /css/styles.php, line
   3163, changed:
 *     ```wp-block-code
       align-items: center;
       ```
   
 * to:
 *     ```wp-block-code
       align-items: flex-start;
       ```
   
 * The rest of 5.3.0 is the plugin update / auto-generation tweaks for multisite
   we discussed.
   [https://github.com/codejp3/bbp-style-pack/archive/refs/heads/pre-pub-5.3.0.zip](https://github.com/codejp3/bbp-style-pack/archive/refs/heads/pre-pub-5.3.0.zip)
 * [@ajtruckle](https://wordpress.org/support/users/ajtruckle/) – don’t worry about
   trying to manually install this one. It’ll be published in the very near future.
 *   Forum: [Plugins](https://wordpress.org/support/forum/plugins-and-hacks/)
    In
   reply to: [[bbp style pack] Was it always like this?](https://wordpress.org/support/topic/was-it-always-like-this/)
 *  [codejp3](https://wordpress.org/support/users/codejp3/)
 * (@codejp3)
 * [3 years, 4 months ago](https://wordpress.org/support/topic/was-it-always-like-this/#post-16442262)
 * [@ajtruckle](https://wordpress.org/support/users/ajtruckle/)
 * It’s displaying the forum icon in the middle/center. On Forums with short descriptions
   or on large screens, the alignment looks fine. On forums with long descriptions
   or devices with small widths, the alignment looks off.
 * I’ll go back through the past 4 plugin releases and see if an “align: top” got
   removed or an “align: center” got added somewhere along the way. It’ll be patched
   in an upcoming release.
 * In the meantime, this custom CSS will align both the unread and the forum icon
   to the “top” regardless of screen width or forum description:
 *     ```wp-block-code
       /* temporary CSS for forum icon alignment */
       li.bbp-forum-info .bsp_thumbnail {
           align-items: flex-start;
       }
       ```
   
 * [@robin-w](https://wordpress.org/support/users/robin-w/) – hold off on releasing
   v5.3.0 until I add this fix to it. 😉
    -  This reply was modified 3 years, 4 months ago by [codejp3](https://wordpress.org/support/users/codejp3/).
      Reason: added @mention
    -  This reply was modified 3 years, 4 months ago by [codejp3](https://wordpress.org/support/users/codejp3/).
      Reason: added @mention note to plugin author
 *   Forum: [Plugins](https://wordpress.org/support/forum/plugins-and-hacks/)
    In
   reply to: [[bbp style pack] Was it always like this?](https://wordpress.org/support/topic/was-it-always-like-this/)
 *  [codejp3](https://wordpress.org/support/users/codejp3/)
 * (@codejp3)
 * [3 years, 4 months ago](https://wordpress.org/support/topic/was-it-always-like-this/#post-16442234)
 * Checking it out now…
 *   Forum: [Plugins](https://wordpress.org/support/forum/plugins-and-hacks/)
    In
   reply to: [[bbp style pack] Future Enhancements](https://wordpress.org/support/topic/future-enhancements-3/)
 *  Thread Starter [codejp3](https://wordpress.org/support/users/codejp3/)
 * (@codejp3)
 * [3 years, 4 months ago](https://wordpress.org/support/topic/future-enhancements-3/#post-16441041)
 * Adding:
 * 20.) Better Font-Family management
 * – Adding a new “Fonts” settings tab
   — Option to select 1.) Default Theme Font,
   2.) Built-in WP Fonts, 3.) Google Fonts—- Google Fonts API key field if Google
   Fonts Selected—- Option to enqueue Google Fonts remotely, or save/enqueue them
   locally—- Option to only enqueue Google Fonts within forum pages, or site-wide
 *  Then EVERY font-family field within the plugin (about 100 of them) would no 
   longer be an empty text field that had to be manually filled in. They would all
   become drop-down select inputs pre-populated with the supported font-families
   based on the settings in the “Fonts” settings tab.
 *   Forum: [Plugins](https://wordpress.org/support/forum/plugins-and-hacks/)
    In
   reply to: [[bbp style pack] Future Enhancements](https://wordpress.org/support/topic/future-enhancements-3/)
 *  Thread Starter [codejp3](https://wordpress.org/support/users/codejp3/)
 * (@codejp3)
 * [3 years, 4 months ago](https://wordpress.org/support/topic/future-enhancements-3/#post-16441021)
 * Adding:
 * 19.) “Login” tab settings overhaul:
   – Better grouping of related options– Logged-
   in redirect options: 1.) back to the previous URL, 2.) custom URL, 3.) Site Home,
   4.) Forum Index– Already Logged-in message/redirect: better setting description
   for clarity– Logged-out redirect options: 1.) back to the previous URL, 2.) custom
   URL, 3.) Site Home, 4.) Forum Index– Already Logged-out message/redirect– Conditional
   check to only show “Select which menus to show XXXX on” if nav_menus array not
   empty & current theme supports nav_menus– Conditional checks to only show “Add
   to nav menu” options if current theme supports nav_menus
 * Most of that is just re-doing what’s already there, with a few extra redirect
   options added to improve the login/logout experience.
 *   Forum: [Plugins](https://wordpress.org/support/forum/plugins-and-hacks/)
    In
   reply to: [[bbp style pack] Multisite Compatibility](https://wordpress.org/support/topic/multisite-compatibility-119/)
 *  Thread Starter [codejp3](https://wordpress.org/support/users/codejp3/)
 * (@codejp3)
 * [3 years, 4 months ago](https://wordpress.org/support/topic/multisite-compatibility-119/page/3/#post-16440763)
 * Awesome! Enjoy it!
 * In the meantime, if you’re OK with it, list me as an [official code commiter](https://developer.wordpress.org/plugins/wordpress-org/special-user-roles-capabilities/#committer)
   and I can handle minor updates to fix any reported issues from users until you
   get back.
 * What I may do during that 2 weeks is another update to whip the translations 
   and gettext strings into shape. Took care of a good chunk already, but there’s
   still some strings not in gettext wrappers, and several that are not 100% gettext
   compliant or machine-translation-friendly. I’d wait until you got back before
   publishing it so you can view it first and have final say on what gets published(
   assuming you make me a code commiter).
 *   Forum: [Plugins](https://wordpress.org/support/forum/plugins-and-hacks/)
    In
   reply to: [[bbp style pack] Styling issue](https://wordpress.org/support/topic/styling-issue-26/)
 *  [codejp3](https://wordpress.org/support/users/codejp3/)
 * (@codejp3)
 * [3 years, 4 months ago](https://wordpress.org/support/topic/styling-issue-26/page/2/#post-16440646)
 * It was a bumpy road….but we got there 🙂
 *   Forum: [Plugins](https://wordpress.org/support/forum/plugins-and-hacks/)
    In
   reply to: [[bbp style pack] Setting are breaking in the last 3 updates](https://wordpress.org/support/topic/setting-are-breaking-in-the-last-2-updates/)
 *  [codejp3](https://wordpress.org/support/users/codejp3/)
 * (@codejp3)
 * [3 years, 4 months ago](https://wordpress.org/support/topic/setting-are-breaking-in-the-last-2-updates/#post-16440644)
 * [@cj74](https://wordpress.org/support/users/cj74/) – perfect! That was the intended
   action: To automatically handle file generations and caches without any end-user
   actions required. 🙂
 *   Forum: [Plugins](https://wordpress.org/support/forum/plugins-and-hacks/)
    In
   reply to: [[bbp style pack] Multisite Compatibility](https://wordpress.org/support/topic/multisite-compatibility-119/)
 *  Thread Starter [codejp3](https://wordpress.org/support/users/codejp3/)
 * (@codejp3)
 * [3 years, 4 months ago](https://wordpress.org/support/topic/multisite-compatibility-119/page/3/#post-16440641)
 * Dare I say it…. we might FINALLY be sorted and have a good solid “stable” starting
   point for all future additions 🙂 ….3 updates later 🙁
 * I do have some other projects to wrap up so I won’t be putting as much time into
   BSP, but as I use the plugin and notice things, I’ll fix/enhance them and send
   the code your way.
 *   Forum: [Plugins](https://wordpress.org/support/forum/plugins-and-hacks/)
    In
   reply to: [[bbp style pack] Future Enhancements](https://wordpress.org/support/topic/future-enhancements-3/)
 *  Thread Starter [codejp3](https://wordpress.org/support/users/codejp3/)
 * (@codejp3)
 * [3 years, 4 months ago](https://wordpress.org/support/topic/future-enhancements-3/#post-16440638)
 * Too bad I can’t edit the post to keep better track of these.
 * ~17.) Change/wrap several “if ( ! empty() )” checks to “if ( isset() )” in order
   to prevent a few random PHP “Not Defined” and “Invalid Array Key” notices when
   an option has no value.~
 * ^ taken care of in v5.2.8
 *   Forum: [Plugins](https://wordpress.org/support/forum/plugins-and-hacks/)
    In
   reply to: [[bbp style pack] Multisite Compatibility](https://wordpress.org/support/topic/multisite-compatibility-119/)
 *  Thread Starter [codejp3](https://wordpress.org/support/users/codejp3/)
 * (@codejp3)
 * [3 years, 4 months ago](https://wordpress.org/support/topic/multisite-compatibility-119/page/3/#post-16440585)
 * [@robin-w](https://wordpress.org/support/users/robin-w/) – I looked at the code
   for 5.2.9 to see what you ended up with. Overall I get it and like it. Serves
   the purpose of only regenerating files when needed, doesn’t rely on hooks that
   may or may not fire as intended, and waits until everything necessary is loaded.
 * One small tweak to the “Handle upgrade actions” code just around line 520-ish
   to take care of a debug message :
 * Only change here was adding:
 *     ```wp-block-code
       $bsp_name = plugin_basename( __FILE__ );
       ```
   
 * before:
 *     ```wp-block-code
       $network_wide = ( is_multisite() && is_plugin_active_for_network( $bsp_name ) ) ? true : false;
       ```
   
 * I was getting “WARNING: bsp_name is not defined” debug messages, and since it
   wasn’t defined, it always made $network_wide = false, so the bsp_plugin_update
   function didn’t do network-activated version updates or re-generations.
 * As an extra precaution, I added this check the top of the bsp_plugin_update function:
 *     ```wp-block-code
               if ( ! function_exists( 'get_plugin_data' ) ) {
                       require_once( ABSPATH . '/wp-admin/includes/plugin.php' );
               }
       ```
   
 * Also, since the bsp_plugin_update function is now only called if “($new_version!
   = $curr_version)”, I removed the duplicate check within the bsp_plugin_update
   function.
 * I went ahead and posted these changes to github as v5.3.0:
   [https://github.com/codejp3/bbp-style-pack/tree/pre-pub-5.3.0](https://github.com/codejp3/bbp-style-pack/tree/pre-pub-5.3.0)
 * Direct Download:
   [https://github.com/codejp3/bbp-style-pack/archive/refs/heads/pre-pub-5.3.0.zip](https://github.com/codejp3/bbp-style-pack/archive/refs/heads/pre-pub-5.3.0.zip)
 * Playing around with it a little more before saying it’s 100% good-to-go, but 
   that was the only issue I encountered on multisite.
 * Since I think I’m currently the only multisite user, the update probably isn’t
   critical to publish immediately. However, anyone who has debugging enabled will
   see the “WARNING: bsp_name is not defined” message, so that may justify publishing
   it sooner.
 *   Forum: [Plugins](https://wordpress.org/support/forum/plugins-and-hacks/)
    In
   reply to: [[bbp style pack] Styling issue](https://wordpress.org/support/topic/styling-issue-26/)
 *  [codejp3](https://wordpress.org/support/users/codejp3/)
 * (@codejp3)
 * [3 years, 4 months ago](https://wordpress.org/support/topic/styling-issue-26/page/2/#post-16440535)
 * [@clivesmith](https://wordpress.org/support/users/clivesmith/) & [@ajtruckle](https://wordpress.org/support/users/ajtruckle/)–
   the updating issues are my fault. Quite a bit was changed within the last 3 versions,
   and while the testing went fine on a dev server with generic settings, it wasn’t
   working right for everyone in all scenarios.
 * I think the underlying issue is worked out now.
 *   Forum: [Plugins](https://wordpress.org/support/forum/plugins-and-hacks/)
    In
   reply to: [[bbp style pack] Setting are breaking in the last 3 updates](https://wordpress.org/support/topic/setting-are-breaking-in-the-last-2-updates/)
 *  [codejp3](https://wordpress.org/support/users/codejp3/)
 * (@codejp3)
 * [3 years, 4 months ago](https://wordpress.org/support/topic/setting-are-breaking-in-the-last-2-updates/#post-16440517)
 * [@cj74](https://wordpress.org/support/users/cj74/) – Blame me. It’s mostly my
   code, and venturing into new territory to make the plugin multisite compatible.
 * I think the underlying issue has been resolved. Are you still experiencing issues
   with 5.2.9?
 *   Forum: [Plugins](https://wordpress.org/support/forum/plugins-and-hacks/)
    In
   reply to: [[bbp style pack] Styling issue](https://wordpress.org/support/topic/styling-issue-26/)
 *  [codejp3](https://wordpress.org/support/users/codejp3/)
 * (@codejp3)
 * [3 years, 4 months ago](https://wordpress.org/support/topic/styling-issue-26/page/2/#post-16438920)
 * [@ajtruckle](https://wordpress.org/support/users/ajtruckle/) – v5.2.8 will be
   released shortly. It includes a fix so that files are automatically re-generated
   when you update the plugin. It’ll take care of you having to “click save” and
   clear cache like [@robin-w](https://wordpress.org/support/users/robin-w/) just
   had you do. It’ll be automatic from here on out.
 *   Forum: [Plugins](https://wordpress.org/support/forum/plugins-and-hacks/)
    In
   reply to: [[bbp style pack] Multisite Compatibility](https://wordpress.org/support/topic/multisite-compatibility-119/)
 *  Thread Starter [codejp3](https://wordpress.org/support/users/codejp3/)
 * (@codejp3)
 * [3 years, 4 months ago](https://wordpress.org/support/topic/multisite-compatibility-119/page/2/#post-16438842)
 * [@robin-w](https://wordpress.org/support/users/robin-w/)
 * 
   GitHub “main” branch updated to the current 5.2.7 version you just published:
   [https://github.com/codejp3/bbp-style-pack](https://github.com/codejp3/bbp-style-pack)
 * 5.2.8 branch created:
   [https://github.com/codejp3/bbp-style-pack/tree/pre-pub-5.2.8](https://github.com/codejp3/bbp-style-pack/tree/pre-pub-5.2.8)
 * Side-by-side comparison:
   [https://github.com/codejp3/bbp-style-pack/compare/pre-pub-5.2.8?expand=1](https://github.com/codejp3/bbp-style-pack/compare/pre-pub-5.2.8?expand=1)
 * Direct Download:
   [https://github.com/codejp3/bbp-style-pack/archive/refs/heads/pre-pub-5.2.8.zip](https://github.com/codejp3/bbp-style-pack/archive/refs/heads/pre-pub-5.2.8.zip)
 * **Code Change Highlights:**
 * 1.) /bsp-style-pack.php
    – activation hook moved to the bottom (probably unnecessary,
   but did it anyways) – new plugin update hook added that performs the activation
   actions on plugin update
 * 2.) /includes/functions.php
    – new function added to check custom CSS locations–
   now also checks if dir exists, and if dir is writable – returns empty array if
   all checks pass – returns an array of current error messages for specified custom
   CSS location – messages re-done to be translatable gettext strings
 * 3.) /includes/generate_css.php
    – only generate/enqueue custom CSS location files
   if there are no errors with the custom location (uses function in #2 above) (
   prevents 500 server errors I was getting when I intentionally gave bad locations)
 * 4.) /includes/settings_css_location.php
    – extra “isset()” checks for text input
   fields to prevent PHP array index warnings – direct error handling removed from
   file – now displays error messages returned by function in #2 above
 * 5.) /includes/settings_breadcrumbs.php
    – extra “isset()” checks for text input
   fields to prevent PHP array index warnings
 * 6.) Topic count files are identical to what was in the official 5.2.7 (now the
   [main branch](https://github.com/codejp3/bbp-style-pack)) so your changes should
   be intact.

Viewing 15 replies - 331 through 345 (of 407 total)

[←](https://wordpress.org/support/users/codejp3/replies/page/22/?output_format=md)
[1](https://wordpress.org/support/users/codejp3/replies/?output_format=md) [2](https://wordpress.org/support/users/codejp3/replies/page/2/?output_format=md)
[3](https://wordpress.org/support/users/codejp3/replies/page/3/?output_format=md)…
[22](https://wordpress.org/support/users/codejp3/replies/page/22/?output_format=md)
23 [24](https://wordpress.org/support/users/codejp3/replies/page/24/?output_format=md)…
[26](https://wordpress.org/support/users/codejp3/replies/page/26/?output_format=md)
[27](https://wordpress.org/support/users/codejp3/replies/page/27/?output_format=md)
[28](https://wordpress.org/support/users/codejp3/replies/page/28/?output_format=md)
[→](https://wordpress.org/support/users/codejp3/replies/page/24/?output_format=md)