Ben
Forum Replies Created
-
Forum: Plugins
In reply to: [WP Meteor Website Speed Optimization Addon] Ditch data-wpmeteor-nooptimizeI have checked your code. You simply block JavaScript without changing the location of the file, that shouldn’t be a problem for modules. But I see possible problems in combination with our plugin if you change JavaScript that has been changed by us and is not allowed to be changed.
In addition, the first customers are already reporting problems: https://wordpress.org/support/topic/exclude-borlabs-cookie-plugin-scripts-issue/
Forum: Plugins
In reply to: [WP Meteor Website Speed Optimization Addon] Ditch data-wpmeteor-nooptimizeHi Alex,
you can keep the data attribute for your JS files, but any other script tag that has a
no-optimize
orno-minify
data attribute should be ignored by your plugin, just like any other caching/optimization plugin does.Otherwise, your plugin will cause conflicts. The same goes for script tags of
type="module"
. These script tags must be ignored; otherwise you will break code.Best regards,
Ben – Developer of Borlabs CookieForum: Themes and Templates
In reply to: [Astra] Rollback CSS adjustmentsWe have investigated the reason for this strange behavior and found several problems. For example, in Astra_After_Setup_Theme::responsive_oembed_wrapper you call wp_oembed_get(), but the responsive_oembed_wrapper() function is called by WordPress and already contains the result of wp_oembed_get() – you call the result twice.
Another problem is how you are trying to add your wrapper around the oEmbed code in Astra_Gutenberg::add_iframe_wrapper(). Your regex breaks the HTML code if more than one div container is part of $block_content.
Since we’ve already waited three months for a solution to a problem you introduced in an update in October, we’ve added a compatibility patch for our plugin to work around the issues caused by Astra.
Forum: Themes and Templates
In reply to: [Astra] Rollback CSS adjustmentsIt’s still not working and I have already written Sudhanshu.
Forum: Themes and Templates
In reply to: [Astra] Rollback CSS adjustmentsI have already informed Sudhanshu about the issue, please check if he received my mail.
Forum: Themes and Templates
In reply to: [Astra] Rollback CSS adjustmentsThe bug is not fixed, your oEmbed modification is still bugged and destroys the code that is returned. Only the CSS rule is fixed, but it’s still broken.
Forum: Themes and Templates
In reply to: [Astra] Rollback CSS adjustmentsHi Herman,
I have already replied to your colleague.
Best regards
BenForum: Themes and Templates
In reply to: [Astra] Rollback CSS adjustmentsHi Herman,
I have responded to your personal mail address.
Best regards,
BenForum: Themes and Templates
In reply to: [Astra] Rollback CSS adjustmentsHi Herman,
can you use an alternative mail address like Gmail? Itβs also recommended not to use a mail address thatβs ends in another ticket system.
Update: your Google Mail server is blocking/filtering our mails.
Forum: Themes and Templates
In reply to: [Astra] Rollback CSS adjustmentsThanks Herman, I have just replied to your ticket with everything you need π
Forum: Themes and Templates
In reply to: [Astra] Rollback CSS adjustmentsHi Herman, itβs not available via the repo, but I can provide you a license. Please contact me via https://borlabs.io/support/
I will monitor the ticket system and will find your ticket (or you can post your ticket id here) and send you everything you need. Thank you very much!Best regards, Ben
Forum: Themes and Templates
In reply to: [Astra] Rollback CSS adjustmentsRepost, because the image links do not work anymore:
Hi Herman, you can see the problem here: https://theme.astra.pandas-playground.com/
The problem is, as already mentioned, this rule:
body .ast-oembed-container * { position: absolute; top: 0; left: 0; width: 100%; height: 100% }
Because of this rule, the video looks like this:
Without this rule, it looks like this:
But you have another issue as well, which could relate to your linked thread. The embedded code is somehow placed twice in the theme.
This only happens with Astra, no other theme has this issue.
Forum: Themes and Templates
In reply to: [Astra] Rollback CSS adjustmentsHi Herman, you can see the problem here: https://theme.astra.pandas-playground.com/
The problem is, as already mentioned, this rule:
body .ast-oembed-container * { position: absolute; top: 0; left: 0; width: 100%; height: 100% }
Because of this rule, the video looks like this:
Without this rule, it looks like this:
But you have another issue as well, which could relate to your linked thread. The embedded code is somehow placed twice in the theme.
This only happens with Astra, no other theme has this issue.
- This reply was modified 5 months, 2 weeks ago by Ben. Reason: Updated the last image
Forum: Plugins
In reply to: [WP Go Maps (formerly WP Google Maps)] Borlabs Cookie HowTo neededFollow this article: https://de.borlabs.io/kb/wp-go-maps/
For support: https://de.borlabs.io/support/Hi @alekv, if you need a developer license of our plugin, please contact us via https://borlabs.io/support/
Best regards
Ben