Forum Replies Created

Viewing 15 replies - 1 through 15 (of 2,477 total)
  • Plugin Author Barry

    (@barryhughes-1)

    Thanks for flagging this! It came to our attention last week and a fix has already been merged (if you upgrade to 6.6.1, you will hopefully find the problem is resolved).

    Plugin Author Barry

    (@barryhughes-1)

    Hi all—please note this problem is now logged as a bug:

    https://github.com/woocommerce/woocommerce/issues/33262

    Thanks!

    Plugin Author Barry

    (@barryhughes-1)

    So if I set that up, and enqueue a scheduled action where the callback throws an exception, method call_failed_execution() is successfully executed and the action_failed_<ID> option is set.

    I’m afraid there’s no obvious answer I can offer you on this occasion, and likely there are factors at play that I can’t see based on the information shared so far.

    if ( has_action ( 'action_scheduler_failed_execution' ) ) { /*...*/ }

    One thing I would note (though perhaps I’m just missing context) is that the above check is probably unnecessary, but I don’t think that is relevant to the actual problem you are facing.

    There probably isn’t much more assistance we can provide right here in the forums, but if you manage to distill this down into something we can easily replicate definitely feel free to follow-up over on the issue tracker.

    Thanks!

    Plugin Author Barry

    (@barryhughes-1)

    Hi @vanbom,

    If I use your code and conspire to make a scheduled action fail (by throwing an exception) then the callback function is successfully called and the action_failed_<ID> option is created/updated.

    In your case:

    • Are you positive the action is failing?
    • Where did you add your code? Asking this because, depending on where or how you added it, it may not be executed early enough.

    Thanks!

    Plugin Author Barry

    (@barryhughes-1)

    Thanks for the note, @musikapublishing.

    There are at least a few possibilities here. The first is that the problem you are facing is, at core, of a different nature to that faced by the OP (even if there are similar symptoms).

    The second is that some of the force downloads were working as expected, and others were not (it may depend on individual file permissions, or it could be that files are stored in a range of different places—some local to your server and some not).

    The third is that the problem is exactly what I outlined, but the difference is explained by the fact that when the preferred option is Force Downloads, an initial attempt is made to serve the file that way and, as part of that attempt, a range of headers (think of these as hints or instructions, if you like) are sent to the browser first of all. Those are mostly incompatible with a redirect (which takes the form of a location header) so it would certainly be unusual but, depending on both the browser being used and actually the server-side setup, it’s just possible that would result in the redirect acting like a force download.

    Plugin Author Barry

    (@barryhughes-1)

    You’re welcome, and our apologies (to everyone) for the disruption.

    Just as a re-cap for others: it is quite possible your digital products were being served via a redirect (even if you had selected Force Download or X-Accel/X-Sendfile in the settings screen). So, changing that setting to Redirect Only is a probable quick fix in most cases and it sounds like a number of you have already discovered that.

    Of course, you may prefer to stick with one of the other options…but if they are not working then some configuration work may be needed. For that, please take a look at (and if you are talking to your hosting provider, refer them to) this article:

    docs.woocommerce.com/document/digital-downloadable-product-handling

    In the meantime we are exploring some further adjustments in response to this issue.

    Plugin Author Barry

    (@barryhughes-1)

    Hi everyone, please see my reply in this thread (which I’ll continue to monitor).

    Plugin Author Barry

    (@barryhughes-1)

    There are quite a few voices in this thread and it’s not absolutely clear that everyone is facing the exact same problem, but let me share some notes that may be useful to at least some of you.

    Currently, WooCommerce supports three different file download methods:

    • Force Downloads
    • X-Accel-Redirect/X-Sendfile
    • Redirect Only

    However, each of those can fail for different reasons. Up until recently one of the ways in which we handled failures was via a set of fallbacks:

    • If the file cannot be served by X-Accel, fallback on Force Download
    • If the file cannot be served by Force Download, fallback on Redirect
    • If the file cannot be served by Redirect, display an error message

    However, in the 5.5.0 release, the fallback on the Redirect method was removed.

    But it does seems odd that this download link functionality worked perfectly for years without the suggested apache module installed on our server…

    Based on this, it is quite likely that you were (perhaps inadvertently) relying on the set of fallbacks I described above. However, the change I described (which was released in 5.5.0) prevented that from happening. What you would likely need to do, to restore things, is either:

    • Explicitly enable the Redirect Only download method (very fast and easy to do, but please read the rest of this note first of all)
    • Or, configure things so that you can successfully use one of the other methods (potentially more complex, depending on your hosting setup, but provides optimal protection for your digital products)

    More advice on digital product handling can be found here:

    docs.woocommerce.com/document/digital-downloadable-product-handling

    As you’ll see mentioned there, an issue to be aware of with the Redirect method is this:

    When users download a file, their link redirects to the file. Using this method means your files will be unprotected and whoever has the upload link will be able to access the file, even when they are not logged in.

    That is why the fallback was removed—we did not want merchants who had selected a method that avoids exposing the source URL of the asset (such as Force Download) to inadvertently have that URL exposed via the Redirect method.

    Thread Starter Barry

    (@barryhughes-1)

    Perfect 🙂

    Thank you!

    Thread Starter Barry

    (@barryhughes-1)

    Excellent! Sorry I missed the earlier report but that’s good news 🙂

    Barry

    (@barryhughes-1)

    Hi @maderacity,

    Stepping back to your original question, there actually is such a notice already. Take a look at this ‘expired event’ from our demo site—you will notice it has a light blue alert box near the top of the page reading, “This event has passed.”

    Shelby’s advice was to help you further customize this but if you are not actually seeing it at all, possibly it has been hidden by your theme or by custom CSS, or something else along those lines? Looking at this event from the URL you shared I suspect this is indeed what has happened.

    Most probably, in your case, it is because you have custom event templates overriding our own. If you weren’t aware of this and didn’t add them yourself then it is quite likely that the theme includes them by default (in which case, I’d recommend reaching out to the theme author for further assistance).

    I hope that helps!

    Barry

    (@barryhughes-1)

    Hi @ankitjoshi11,

    The latest version should work well with WordPress 5.2.1 and so we’ve updated the “tested up to” field accordingly (but do note we are not releasing a new version of the plugin at this time).

    Thanks for flagging this!

    Barry

    (@barryhughes-1)

    Thanks for flagging this and apologies for the inconvenience…we’ve now corrected things 🙂

    Barry

    (@barryhughes-1)

    Hi @stepheybaker,

    We work really hard to make The Events Calendar as flexible and visually attractive as we can: in fact, we like to think that the layouts and styling decisions embedded within the plugin are just opinionated enough to achieve exactly that, while still meshing nicely with most well-written themes.

    Given that, we’re sorry to hear The Events Calendar didn’t meet your expectations. I’d like to think though, that for most customers, an aesthetically pleasing calendar is indeed what they get straight out of the box. Here’s a link to the main calendar view on our demo site, as an example:

    wpshindig.com/events

    We’re running a minimally-modified default WordPress theme there, so this ought to be close to what most users see. Additionally, thinking of your note about it being hard to add a header or other content around the calendar, we do provide things like the “Add HTML Before/After Calendar” setting (described here) and solid integration with the WordPress theme customizer (described here).

    I’m not sure about the specific challenges you faced in the context of your site (and the particular mix of themes and plugins you were using) or what more we could have done to support you—best I can tell, I don’t think you reached out in the community forums before posting this review—but if you do have an opportunity to take our calendar for a spin in the future, and want to provide some more specifics about any challenges you are facing, then perhaps we or other members of the community will be able to assist.

    Though we’re sorry you feel your time was wasted, thank you for giving us a try and taking a moment to share this feedback.

    Barry

    (@barryhughes-1)

    Hi! Looks like your child theme has some code that tries to call functions provided by APM:

    vip.hikingwithdean.com/wp-content/themes/enfold-child/functions.php:54

    If you’re comfortable doing so, open that file up in the editor, scoot down to line 54 and remove the problematic code (or add some safety checks around it).

    If a developer/designer put that child theme together on your behalf, you may wish to reach out to them for further assistance: but I don’t think this is actually a problem in APM itself, rather the issue is squarely in the child theme 🙂

Viewing 15 replies - 1 through 15 (of 2,477 total)