Support » Plugin: Complianz | GDPR Cookie Consent » Youtube player changes in size

  • Maartenvveen

    (@maartenvveen)


    Hi guys,

    In Complianz, I finally found a cookie plugin that works! You guys are the best.
    the Wizard/turtorial was very helpful as well.

    There is one thing that confuses me, on activating the plugin it changes the size of my embedded youtube players. Is there any way to fix this? Because while it funtions correctly (blocking the video until consent is given) it doesn’t look as pretty.

    Thanks in advance for your reply.

Viewing 15 replies - 46 through 60 (of 84 total)
  • I actually have

    n(".cmplz-video").each(function(e,o){n(this).height("inherit")})

    in cookieconfig.min.js.

    It seems to be your change, but it does not work, the injected height is still there…

    Content notice is no longer centered vertically too.

    I restored the centering of the content notice and it seems to work …

    Plugin Author RogierLankhorst

    (@rogierlankhorst)

    I’m playing a bit with the position of the content notice. Vertically centering does not always work, in which case it might get positioned outside the frame. Positioning it at a fixed distance from the top fixes that.

    It all depends on the wrapping html and CSS.

    Thin, when cookies are accepted, Dailymotion loses the Fitvids ID and the div injected by it.

    Plugin Author RogierLankhorst

    (@rogierlankhorst)

    The FitVids() function is called on the parent div, like with the youtube video’s I can’t say why it isn’t working here. There’s no difference in the code for youtube or dailymotion.

    Found: the call to Fitvids in my theme for DailyMotion was in question.
    I corrected and everything seems to work now.

    Thank you Rogier.

    I remain at your disposal to contribute by testing.

    Plugin Author RogierLankhorst

    (@rogierlankhorst)

    Thanks for the input!

    If you run into anything, let me know.

    Plugin Support Aert Hulsebos

    (@aahulsebos)

    @bonaldi @rogierlankhorst @maartenvveen,

    Our Beta Release of 3.0 is here: https://github.com/rlankhorst/complianz-gdpr

    We went deep into the video & placeholder compatibility, and because of your prompt and insightful feedback, we’d like to ask you if you were interested in testing our next release?

    We would like to focus on the video placements and placeholders.

    Let me know if you’re interested in making this a longer thread:)

    Regards Aert

    Hi Aert,
    OK, I’ll check the beta…
    Regards.

    Hi @rogierlankhorst and @aahulsebos,

    I noted, for instance, that the video & placeholder compatibility was not good with the use of mixed content Classic editor contents and Gutenberg blocks: a blog that goes from the old publisher to the new one, but has embedded videos with the old one before, will not display them as with Gutenberg: everyone will proceed to a treatment and the UI will be broken.

    It therefore seems useful to study overwriting phenomena and to take into account, for example, the use in the themes of new support:

    // Add support for Gutenberg cover image sizes
    	add_theme_support( 'align-wide' );
    // Add support for Gutenberg responsive embeds
    	add_theme_support( 'responsive-embeds' );

    Perhaps it will be useful to test the type of editor used before display.

    I’ll check your beta version asap and I’m coming back to you to tell you what problems it is solving and what problems it can create.

    Regards

    I replaced with the beta.
    It seems that the YouTube placholder is not found: it is the default image that appears.
    For Vimeo and Dailymotion the image is well loaded since “Uploads”.

    @rogier Have you kept the address of my test server (confidential)?
    If necessary, I’ll send it back from complianz.io …

    After validation of the notice, the YouTube video is normally displayed.
    These tests are done with WordPress 5.1.1 and the Gutenberg editor.
    I will test on another server with the Classic editor.
    Then on a server with mixed contents.

    Get these notices when I active plugin on WordPress 4.9.10 localhost multisite:

    
    Warning: count(): Parameter must be an array or an object that implements Countable in /home/myserver/www/wordpress/wp-content/plugins/complianz-gdpr-master/config/documents/cookie-policy.php on line 107
    
    Warning: count(): Parameter must be an array or an object that implements Countable in /home/myserver/www/wordpress/wp-content/plugins/complianz-gdpr-master/config/documents/cookie-policy-us.php on line 115

    You need to test properly count() for a php 7 use : count() will now yield a warning on invalid countable types passed to the array_or_countable parameter.

Viewing 15 replies - 46 through 60 (of 84 total)
  • The topic ‘Youtube player changes in size’ is closed to new replies.