Support » Plugin: Font Awesome » you renamed you plugin.php file causing deactivation on my client sites

  • Resolved mariodabek

    (@mariodabek)


    Why would you rename your plugin.php activation file on this plugin and rename it to font-awesome.php !?!??!

    You do know anyone who had your plugin running, my clients included, all had the plugin deactivated when they ran their updates because you renamed the files right ?

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author mlwilkerson

    (@mlwilkerson)

    Sorry, no, I didn’t realize it would have that effect. I’m sorry for the trouble that’s caused. We’ve recently taken the handoff of the old plugin that was here in this namespace. So the codebase is entirely new, it just lives in the same namespace. But my goal has been to provide a reasonably smooth upgrade path for users of the old plugin. I didn’t realize that using a different naming convention for the entry point plugin file would have the effect that you described.

    Now we’ll need to figure out which is the better approach going forward: to document this part of the upgrade path? (Which would just be: reactivate after upgrading to 4.0, right?) Or to rename the file back to plugin.php, which would then cause the same effect for all of those clients who’ve already installed the new version.

    Come to think of it, given that this is such a major change (and this is still a development / release candidate, by the way, because we’re still discovering and ironing out wrinkles like this), maybe it’s no so bad that a user of the previous plugin would hit this speed bump and slow down to notice the huge change and need to be mindful of the rest of the upgrade path, most notably, the deprecation of v3 icon names.

    Your thoughts?

    Plugin Author mlwilkerson

    (@mlwilkerson)

    Resolving this for now, since we don’t have any current plan to change the plugin’s design. But I’m open to continuing the conversation.

Viewing 2 replies - 1 through 2 (of 2 total)
  • You must be logged in to reply to this topic.