WP6.1 gets stuck in maintenance mode

To add to this, on one site I am testing with the site remains in maintenance mode for minutes and then resolves.

This is unusual behaviour

so I dig a bit deeper

looking at the code suggests that the wrong file type is being sent to the function.

it shouldn’t be trying to use ftp_rmdir() it should be using ftp_delete( $this->link, $file );

/**
* Deletes a file or directory.
*
* @since 2.5.0
*
* @param string $file Path to the file or directory.
* @param bool $recursive Optional. If set to true, deletes files and folders recursively.
* Default false.
* @param string|false $type Type of resource. ‘f’ for file, ‘d’ for directory.
* Default false.
* @return bool True on success, false on failure.
*/
public function delete( $file, $recursive = false, $type = false ) {
if ( empty( $file ) ) {
return false;
}

if ( ‘f’ === $type || $this->is_file( $file ) ) {
return ftp_delete( $this->link, $file );
}

if ( ! $recursive ) {
return ftp_rmdir( $this->link, $file );
}

$filelist = $this->dirlist( trailingslashit( $file ) );

if ( ! empty( $filelist ) ) {
foreach ( $filelist as $delete_file ) {
$this->delete( trailingslashit( $file ) . $delete_file[‘name’], $recursive, $delete_file[‘type’] );
}
}

return ftp_rmdir( $this->link, $file );
}`

This is clearly a bug somewhere else, and since it’s only affecting filesystem-ftpext.php it’s why using FS_direct fixes it.

Backtracking to where the function is called from to see why it’s not passing filetype next…