Support » Plugin: WP eCommerce » wp-e-commerce/trunk/bin/install-wp-tests.sh is an executable

  • Resolved JS Morisset

    (@jsmoriss)


    Why are you installing an executable script as part of your plugin?

    wp-e-commerce/trunk/bin/install-wp-tests.sh

    js.

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author Justin Sainton

    (@justinsainton)

    Fairly innocuous, it’s a simple unit test scaffold.

    Moderator Ipstenu (Mika Epstein)

    (@ipstenu)

    🏳️‍🌈 Plugin Review Team Rep

    Please don’t tag these as ModLook.

    YES it should be removed (it makes your plugin needlessly larger to include tests like that), but since it doesn’t cause a risk, its allowed.

    Note, YES if someone can run shell scripts from the browser on your server, you have a problem. But that would indicate that you have a huge security issue, or you have another plugin/script that runs it via PHP, which … yeah. That’s a lot of IF in there.

    I would recommend you remove it (put it in an svnignore file) because it doesn’t have to be in the plugin.

    Plugin Author Justin Sainton

    (@justinsainton)

    Will do, thanks Mika!

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘wp-e-commerce/trunk/bin/install-wp-tests.sh is an executable’ is closed to new replies.