Support » Alpha/Beta/RC » WP 6.1-RC3: `menu-item-has-children` class is not being applied correctly

  • When a theme has depth > 0 parameter set for wp_nav_menu(), WordPress 6.1-RC3 stops applying menu-item-has-children class for sub-menu items and only top level menu items obtain the class.

    The issue is not present if depth parameter is not set or is set as 0.

    For testing check out my Michelle theme, for example. Once you set $args['depth'] = 0; on line #111 of includes/Menu/Component.php file, the issue is resolved.

    This worked perfectly fine with previous versions of WordPress though, so I think it is a WP6.1 bug.

Viewing 9 replies - 1 through 9 (of 9 total)
  • That seems to be related to this change here:
    https://core.trac.wordpress.org/changeset/54478

    This should now more accurately check if the menu items have sub-items.

    I just tested this with 6.1-RC6. There I can not understand it. I have built a menu with your theme (version 1.3.11) where a main menu item has a subitem and this subitem also has a subitem. All 3 menu items have got the class “menu-item-has-children” at their <li> element. Therefore, I am not able to reproduce this.

    By the way, nothing else has changed in the modified file since the above change: https://github.com/WordPress/WordPress/blob/master/wp-includes/nav-menu-template.php

    • This reply was modified 3 weeks, 5 days ago by threadi.
    Thread Starter WebMan Design | Oliver Juhas

    (@webmandesign)

    Thank you for your input.

    Your solution works only if you have less items than the number the depth parameter is set to. In Michelle theme this is set to 4, so your menu with 3 items works fine.

    There seems to be some issue with the https://core.trac.wordpress.org/changeset/54478 code as when I do print_r( $menu_items_with_children ); on line #217 (so, just before if ( $menu_items_with_children ) { block of code) and check the output, the depth number for sub-menu item is wrong, too large.

    So, no matter what I do, I still get the error with WP 6.1-RC6-54737 version when using “large” menu. Try to test it with theme unit test (https://codex.wordpress.org/Theme_Unit_Test) and set the menu “All pages” for menu location “Primary”. Then you should experience issue with sub-menus under “Level 1” top level menu item.

    Ok, so I have now created 8 sub-items in my menu item. The class is still set to the menu item.

    <li id="menu-item-1954" class="menu-item menu-item-type-custom menu-item-object-custom menu-item-has-children menu-item-1954 menu-item-is-depth-0 a11y-menu--has-children"><a data-submenu-label="main" href="http://.">main</a>
    <button aria-expanded="false" class="button-toggle-sub-menu" aria-label="Expand menu: main"></button><ul class="sub-menu">
    	<li id="menu-item-1950" class="menu-item menu-item-type-custom menu-item-object-custom menu-item-1950 menu-item-is-depth-1"><a href="http://.">a</a></li>
    	<li id="menu-item-1951" class="menu-item menu-item-type-custom menu-item-object-custom menu-item-1951 menu-item-is-depth-1"><a href="http://.">b</a></li>
    	<li id="menu-item-1952" class="menu-item menu-item-type-custom menu-item-object-custom menu-item-1952 menu-item-is-depth-1"><a href="http://.">c</a></li>
    	<li id="menu-item-1953" class="menu-item menu-item-type-custom menu-item-object-custom menu-item-1953 menu-item-is-depth-1"><a href="http://.">d</a></li>
    	<li id="menu-item-1955" class="menu-item menu-item-type-custom menu-item-object-custom menu-item-1955 menu-item-is-depth-1"><a href="http://.">e</a></li>
    	<li id="menu-item-1956" class="menu-item menu-item-type-custom menu-item-object-custom menu-item-1956 menu-item-is-depth-1"><a href="http://.">f</a></li>
    	<li id="menu-item-1957" class="menu-item menu-item-type-custom menu-item-object-custom menu-item-1957 menu-item-is-depth-1"><a href="http://.">g</a></li>
    </ul>
    </li>

    var_dump results in:

    array(1) {
      [1954]=>
      &int(1)
    }

    Another test with sub-sub-menu:

    <li id="menu-item-1954" class="menu-item menu-item-type-custom menu-item-object-custom menu-item-has-children menu-item-1954 menu-item-is-depth-0 a11y-menu--has-children"><a data-submenu-label="main" href="http://.">main</a>
    <button aria-expanded="false" class="button-toggle-sub-menu" aria-label="Expand menu: main"></button><ul class="sub-menu">
    	<li id="menu-item-1950" class="menu-item menu-item-type-custom menu-item-object-custom menu-item-has-children menu-item-1950 menu-item-is-depth-1 a11y-menu--has-children"><a data-submenu-label="a" href="http://.">a</a>
    	<button aria-expanded="false" class="button-toggle-sub-menu" aria-label="Expand menu: a"></button><ul class="sub-menu">
    		<li id="menu-item-1951" class="menu-item menu-item-type-custom menu-item-object-custom menu-item-1951 menu-item-is-depth-2"><a href="http://.">b</a></li>
    		<li id="menu-item-1952" class="menu-item menu-item-type-custom menu-item-object-custom menu-item-1952 menu-item-is-depth-2"><a href="http://.">c</a></li>
    		<li id="menu-item-1953" class="menu-item menu-item-type-custom menu-item-object-custom menu-item-1953 menu-item-is-depth-2"><a href="http://.">d</a></li>
    		<li id="menu-item-1955" class="menu-item menu-item-type-custom menu-item-object-custom menu-item-1955 menu-item-is-depth-2"><a href="http://.">e</a></li>
    		<li id="menu-item-1956" class="menu-item menu-item-type-custom menu-item-object-custom menu-item-1956 menu-item-is-depth-2"><a href="http://.">f</a></li>
    		<li id="menu-item-1957" class="menu-item menu-item-type-custom menu-item-object-custom menu-item-1957 menu-item-is-depth-2"><a href="http://.">g</a></li>
    	</ul>
    </li>
    </ul>
    </li>

    var_dump results here in:

    array(2) {
      [1954]=>
      int(1)
      [1950]=>
      &int(2)
    }

    If you still consider it as a bug, I would recommend opening a ticket in core so the developers can take a look at it: https://core.trac.wordpress.org

    Thread Starter WebMan Design | Oliver Juhas

    (@webmandesign)

    I think I can see where the issue is in the https://core.trac.wordpress.org/changeset/54478 code: the foreach cycle on line #209 should not be nested within previous foreach cycle. It should follow instead.

    So, the code should be updated from current:

    	foreach ( (array) $menu_items as $menu_item ) {
    		$sorted_menu_items[ $menu_item->menu_order ] = $menu_item;
    		$menu_items_tree[ $menu_item->ID ]           = $menu_item->menu_item_parent;
    		if ( $menu_item->menu_item_parent ) {
    			$menu_items_with_children[ $menu_item->menu_item_parent ] = 1;
    		}
    
    		// Calculate the depth of each menu item with children
    		foreach ( $menu_items_with_children as $menu_item_key => &$menu_item_depth ) {
    			$menu_item_parent = $menu_items_tree[ $menu_item_key ];
    			while ( $menu_item_parent ) {
    				$menu_item_depth  = $menu_item_depth + 1;
    				$menu_item_parent = $menu_items_tree[ $menu_item_parent ];
    			}
    		}
    	}

    to this:

    	foreach ( (array) $menu_items as $menu_item ) {
    		$sorted_menu_items[ $menu_item->menu_order ] = $menu_item;
    		$menu_items_tree[ $menu_item->ID ]           = $menu_item->menu_item_parent;
    		if ( $menu_item->menu_item_parent ) {
    			$menu_items_with_children[ $menu_item->menu_item_parent ] = 1;
    		}
    	}
    
    	// Calculate the depth of each menu item with children
    	foreach ( $menu_items_with_children as $menu_item_key => &$menu_item_depth ) {
    		$menu_item_parent = $menu_items_tree[ $menu_item_key ];
    		while ( $menu_item_parent ) {
    			$menu_item_depth  = $menu_item_depth + 1;
    			$menu_item_parent = $menu_items_tree[ $menu_item_parent ];
    		}
    	}

    After this change everything works as it should.

    I had already written you a reply, but it’s still probably in the mod queue due to spam detection in the source codes I sent along.

    Therefore here still briefly: create best a ticket in the core track with your findings. The developers there can then evaluate it: https://core.trac.wordpress.org

    Thread Starter WebMan Design | Oliver Juhas

    (@webmandesign)

    OK, I don’t know the logic when it stops working, but it still does not work (except when using the code edit I’ve proposed). Please test with theme unit test to see.

    Thank you for help, I will log a ticket in core trac.

    Moderator Marius L. J.

    (@clorith)

    Adding that a ticket was opened at https://core.trac.wordpress.org/ticket/56946 for this.

    I’m marking the thread here as resolved, as further discussions or new information should be shared in the ticket, to avoid missing any potentially important information.

    Hi
    I am having major issues since the 6.1 update I did a few days ago where I now get a php error above my menu:

    Warning: Undefined array key 74 in /homepages/15/d4296702086/htdocs/wordpress/wp-includes/nav-menu-template.php on line 210

    At first I thought it could be a plugin conflict, but I checked every plugin and the problem still persist. I then checked the theme, tried different themes and it was still the same. No matter what menu type I used that issue continued.

    I then read that it was a bug with the new WP 6.1 update and that to get round the issue, I had to delete my menu and recreate. This fix temporally worked and then the php error happened again and I noticed that it was when I added empty menu items in my menu with sub menu items and this seemed to cause the php error to show above the menu.

    This has become so stressful as there appears to be no fix.

    I don’t know if what you guys are discussing is related, but I desperately need a fix.

    @gumbopop: please open your own topic for your own issue: https://wordpress.org/support/forum/alphabeta/#new-topic-0

Viewing 9 replies - 1 through 9 (of 9 total)
  • You must be logged in to reply to this topic.