Hi @ahmad979585,
Thanks for the feedback. Please update the plugin to the latest v1.4.3 (released just a couple of minutes ago). Then in each field’s “Datepicker/Weekpicker Type Options” settings section, you will find new “Datepicker: Timepicker addon” checkbox. This will add time to the datepicker. Please give it a try and let me know if something is not working as expected, or if you have any questions/comments.
I have tried the updated version. This is much more easier now that we can add date with time add on.
Functionally , for me it is working nicely and stable.
A suggestion ,that in my opinion will add value to the plugin, would be to add holidays or specific date exclusions and time ranges. Since the feature is borrowed from time picker and datepicker, it is doable as i have tweaked this plugin to do such although in longer run, not a good idea to modify plugins .
All in All, awesome work.
@ahmad979585,
Happy to hear you liked the timepicker addon.
As for “… specific date exclusions and time ranges…” – will add that in next plugin version.
Hi @ahmad979585,
As promised, we’ve just released new plugin v1.4.4, where I’ve added:
- “Datepicker: Exclude dates” option to the “Datepicker/Weekpicker Type Options” section.
- “Min time” and “Max time” options to a) “Datepicker: Timepicker addon”, and also to b) “Timepicker Type Options” sections.
Please give it a try and let me know what you think.
You guys are rock stars.
As before, seamless and has not affected any existing site functionality.
Your implementation method for the ideas is really good and the feature overall adds great value to the plugin.
Hi @ahmad979585,
Glad to hear that it’s working properly. Let me know if you need anything else.
P.S. Would you mind reviewing your rating? 😉
Hi There. Reviewed my rating and missed out something from from earlier.
The time picker should allow am/pm time since most people do not like to use military time.
The time-picker add on uses that.
Hi @ahmad979585,
Sure, please give me 24 hours or so to add time format option to the “Datepicker: Timepicker addon”.
P.S. Thank you for reviewing the rating!
Not to alarm you but i just found something that appears to be a glitch. I checked with atleast 3 other themes to be sure.
Say we select a date with the datepicker with time addon.
Of we select the date picker field again and do not change the value (maybe click outside the field), the time-picker value sets itself to default value on its own without any direct intervention.
Say default is 12:00
if i change it to 13:45 and focus out and click the field again, not change the value and click anywhere outside the field, the value reverts to 12:00.
Hi @ahmad979585,
First of all – we’ve just released new v1.4.5, where I’ve added “Timepicker addon: Time format” option to the “Datepicker: Timepicker addon”. For 12-hour AM/PM format, you would need to set it to something like hh:mm TT (full formatting specifications can be found here). Please give it a try and let me know if something is not working as expected.
Now regarding the latest issue with the default time. Unfortunately, I was not able to reproduce it on my test server (I’m testing with Storefront theme). Will be trying further… Could you please let me know how did you set the default time?
The base feature is A okay and can add the AM/Pm as needed.
For the other issue, I do think it is something that the theme is responsible for but still want to let you know .
By default time: I meant the time ranges i had set for the timepicker. sorry for confusion. In the video link attached, the ranges are 12pm to 21pm for instance. So it picks either the boundary value somehow.
I attached a video of it here .
-
This reply was modified 3 months, 1 week ago by
ahmad979585.
@ahmad979585,
Thanks for the feedback. I’ve checked the video… It’s going back to 21:00 – did you set it as default value anywhere?
@ahmad979585,
Ok, so it’s a boundary… Let me try to reproduce it on my server…
@ahmad979585,
Ok, I think I figured out what’s going on. The problem only occurs if you use HH:mm TT format (as it is in your video). If you replace it with hh:mm TT format, it seems to be working fine. I believe it’s because HH:mm TT is actually not a correct format (i.e. you shouldn’t be using 24-hour format with AM/PM, only 12-hour format). Could you please give it a try and let me know if that solves it?
Yeah I wanted to point that out as well that we have no need for AM/PM in a 24 hour format.
hh:mm TT actually worked in this case and does not remove the time. Maybe that was the glitch but it worked on all my sites.
As always thank you and awesome job.
-
This reply was modified 3 months, 1 week ago by ahmad979585.
