Works as advertised, but could use some improvements

  • Clicknathan

    (@clicknathan)


    8 years, 8 months ago

    I would simply suggest:

    1. Do a check to see if the shortcode exists in the_content before outputting the additional 2 CSS and 2 JS files, no one wants to slow down every page on their site just to have this on some pages.

    2. Removing the need (and nag) to install the additional plugin to get the shortcode generator to work.

    For anyone who doesn’t realize you can see all of the available shortcodes in the plugin’s readme.txt, here they are:

    Basic requirements to get it to work:

    [image-comparator left=”your-image-url-here.jpg” right=”the-second-image-url.jpg”][/image-comparator]

    [image-comparator left=”your-image-url-here.jpg” right=”the-second-image-url.jpg” left_alt=”alt text for the left image” right_alt=”alt text for the right image” title=”optional title” width=”150px” classes=”anything-you-want hover”][/image-comparator]

    The plugin author recommends using fixed width images so the “width” should be set to a XXXpx not XXX%.

    Adding classes=”hover” will enable the hover effect, so you don’t need to use the slider below the image.

Viewing 1 replies (of 1 total)
  • Plugin Author Adrian

    (@adrian2k7)

    8 years, 8 months ago

    Hi Nathan,

    Thanks for your feedback. Don’t know why only 3 stars, if it “works as advertised”, but it’s your opinion anyway.

    Regarding your suggestions.

    1. You are right, no one wants to slow down a page. But I still think this is the best way, as it allows improved caching and combining of files.
    Just to extend a little bit. Loading every needed script on every page allows to just create one combined file (or a few).
    Using different scripts on multiple pages means different caching pathes, which essentially results in less effective caching, as every page has it’s own signature and therefor a new combined caching file. That’s also the reason I don’t ship minified versions out of the box.
    Of course I expect that everyone uses some caching and combining, which is strongly recommended.

    2. This is just optional. There is no need to install it. As you already noted, it is just possible to insert the shortcode manually. (If you want you can find a lot of people wanting to pay us to develop our own shortcode generator, whithout using handy framework 😉

    Greetz,

    Adrian

Viewing 1 replies (of 1 total)
  • The topic ‘Works as advertised, but could use some improvements’ is closed to new replies.