Support » Plugin: Simple Membership » WordPress 5.3 Incompatibility

  • Hi there,

    In WordPress 5.3, changes were made to the way dates and times work. See this post: https://make.wordpress.org/core/2019/09/23/date-time-improvements-wp-5-3/

    In particular, the function date_default_timezone_set is no longer recommended and in fact causes havoc with other plugins that use date functions. In particular, I experienced a problem with Modern Tribe’s Events Calendar plugin, where the timezone of events was being overridden by Simple Membership’s use of the date_default_timezone_set function, causing events to show up in some cases on the wrong day.

    I resolved the problem by commenting out the use of the function in your plugin in the following places:

    simple-membership/lib/braintree/lib/Braintree/WebhookTestingGateway.php line 553
    simple-membership/lib/braintree/lib/Braintree/WebhookTestingGateway.php line 555
    simple-membership/classes/class.swpm-utils.php line 29

    Of course, my edits will be written over the next time my client updates your plugin. Hopefully you can include the necessary changes in the next update!

    Hope this helps anyone else who may have encountered this problem.

    Thank you very much for your work!

    – Kyle

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Support mbrsolution

    (@mbrsolution)

    Thank you for reporting this issue. I have contacted the developers to investigate further your findings.

    Thank you

    Plugin Author wp.insider

    (@wpinsider-1)

    Thank you. We will update it accordingly in the next release of the plugin.

    Plugin Support mbrsolution

    (@mbrsolution)

    @dvelyk, please install the latest version. Let us know if it works for you now.

    Thank you

    @mbrsolution @wpinsider-1

    Thanks for your prompt replies! The problem returned when I updated to the latest version of the plugin. It looks like the calls to date_default_timezone_set were commented out in simple-membership/lib/braintree/lib/Braintree/WebhookTestingGateway.php only.

    Commenting out line 29 in simple-membership/classes/class.swpm-utils.php fixed the issue.

    Plugin Support mbrsolution

    (@mbrsolution)

    Thank you for reporting back. I have contacted the developers to investigate further this issue.

    Regards

    Plugin Author wp.insider

    (@wpinsider-1)

    That’s because you have manually went to the “Advanced Settings” menu of this plugin and checked the following checkbox:

    
    Use WordPress Timezone
    

    Please uncheck that option from the settings since that one is not needed for you. That option is for certain users who want to execute that function call.

    Once you unchecked that checkbox, it won’t be executed on your site anymore.

Viewing 6 replies - 1 through 6 (of 6 total)
  • You must be logged in to reply to this topic.