Hi Alan,
In your case there are no javascript errors (depending on the exact browser you would hit F12 on your keyboard and go to the console window), but I’m also not seeing any HTML output either. What is the full shortcode you’re using and when you upgraded to 4.5.2 did you upgrade anything else at the same time? Like I’ve noted in the other threads, there’s nothing inherent in 4.5.2 that my plugin is incompatible with so it’s just a matter of figuring out what caused the trouble.
Thread Starter
Alan
(@arr)
Hi John
Thanks for the response. The shortcode I have for testing just says [faq]. After playing, I have found that if I comment out the line
$html = apply_filters( 'arconix_faq_toggle_output', $html );
in the display file then things work. I have also found that setting the style to accordion works, so it seems to be something to do with toggle.
I’m not sure what the above line does? From a bit of Google it looks like it should call a function called arconix_faq_toggle_output but I haven’t been able to find this. Any suggestions?
Thanks
Alan
The apply_filters() function (as I’ve used it) allows advanced users the ability to completely override how the toggle output is handled.
What I find interesting about your findings is the accordion works but the toggle doesn’t. If you look at the code the setup for the filter is the same, with just the filter name changing (the accordion is arconix_faq_accordion_output). That the accordion works but the toggle doesn’t leads me to believe perhaps a plugin or the theme is interacting with the toggle filter and it’s erroring out unintentionally.
Ideally, we’d like to find what’s interacting with that filter, but in the meantime you can certainly leave that line commented out.
Thread Starter
Alan
(@arr)
Hmm now you’ve got me wondering if I’ve shot myself in the foot here 🙂 I last played with this many moons ago so am wondering if I might have tried to implement a filter. I’m not even sure how you’d do that now so I’m off to google :p
Thread Starter
Alan
(@arr)
Yep self inflicted :s I did have a filter function in place for arconix_faq_toggle_output and it was calling back to your original return_to_top function to create the required hyperlink. That is now marked as private so was failing. I’ve now implemented my own copy of the function for that so I don’t have to call the one in your class.
Thanks for the help and the pluggin 🙂
Alan
I’m glad to hear everything worked out. I don’t know why I marked those methods as private… they should be public. I’ll fix that in the next release.
