WordPress 4.8 and Super Emoji Plus breaks visual editor

  • Resolved David Artiss

    (@dartiss)


    6 years, 10 months ago

    Hi Eric,

    As briefly discussed on Twitter, I work for the WordPress VIP team at Automattic. WordPress.com has been updated with some of the TinyMCE features that are to be added into WordPress 4.8 (currently in beta) and we’ve found that this plugin causes the Visual editor to break when the two are brought together. I’m running the 4.8 beta on my own self-hosted test site and can recreate the exact same issue – basically, once both are active, when you enter the editor the visual tab has no content. If you switch to the text/html tab you can see the post content – click back on the visual tab and it re-appears.

    In case you’re wondering how this plugin and WordPress.com have ever met, one of our VIP clients uses it (VIP users can add additional plugins above those built into wp.com).

    So, here’s the JavaScript error I’m seeing…

    tinymce.min.js?ver=4603-20170530:10
Uncaught Error: Could not find control by type: sepemojiinput
    at Object.create (tinymce.min.js?ver=4603-20170530:10)
    at Array.<anonymous> (plugin.min.js?wp-mce-4603-20170530:1)
    at b (tinymce.min.js?ver=4603-20170530:2)
    at Object.c [as _createToolbar] (plugin.min.js?wp-mce-4603-20170530:1)
    at o.<anonymous> (script.js?version=0.1.4&wp-mce-4603-20170530:14)
    at b.e [as fire] (tinymce.min.js?ver=4603-20170530:10)
    at o.fire (tinymce.min.js?ver=4603-20170530:10)
    at Object.y [as initContentBody] (tinymce.min.js?ver=4603-20170530:13)
    at Object.q [as init] (tinymce.min.js?ver=4603-20170530:13)
    at o.<anonymous> (tinymce.min.js?ver=4603-20170530:13)

    Not surprisingly, I suspect that once WordPress 4.8 is pushed out that SEP is going to break for all updated sites.

    Anyway, don’t hesitate to ask if you need any further help with this.

Viewing 8 replies - 1 through 8 (of 8 total)
  • Plugin Author Eric Andrew Lewis

    (@ericlewis)

    6 years, 10 months ago

    Thank you for this bug report! I’m going to take a look at this tonight.

    Plugin Author Eric Andrew Lewis

    (@ericlewis)

    6 years, 10 months ago

    I’ve updated the plugin to 1.0.0 which deactivates the plugin on upgrade. Unfortunately I am not familiar enough with TinyMCE changes in new versions to keep up this plugin. Hopefully users can at this point expect their operating systems to provide good emoji input support.

    Plugin Author Nikola Nikolov

    (@nikolovtmw)

    6 years, 10 months ago

    Hi Eric,

    Not a user of the plugin, but stumbled across this as I faced the same error in my own plugin 😀 After taking a quick look at TinyMCE’s source code, I found out that technically we’re supposed to register custom controls like this:

    tinymce.ui.Factory.add( 'name', class )

    instead of like this:

    tinymce.ui.name = class

    So in order to fix this in your plugin, you just have to update this line: https://plugins.trac.wordpress.org/browser/super-emoji-plus/trunk/script.js#L74 to be

    tinymce.ui.Factory.add('SEPEmojiInput', tinymce.ui.Control.extend( {

    And then of course don’t forget to add an extra closing bracket ) at https://plugins.trac.wordpress.org/browser/super-emoji-plus/trunk/script.js#L212

    I tested and the fix seems to work with 4.7.3 as well, so you can probably make that tweak.

    dfl1955

    (@dfl1955)

    6 years, 10 months ago

    Did this make it into the release. I have just upgraded to WP 4.8 and had to deactivate the plugin.

    I have version 0.1.4. The button interface is good, it would be good if this was updated,

    Plugin Author Eric Andrew Lewis

    (@ericlewis)

    6 years, 10 months ago

    Did this make it into the release.

    No, I’m looking for maintainers to take over this plugin.

    Plugin Author Nikola Nikolov

    (@nikolovtmw)

    6 years, 10 months ago

    Hi @dartiss and @dfl1955 and anyone else who might be watching this issue – I’m glad to say that the issue is resolved and you should be able to update to 0.1.5 which works with WordPress 4.8

    I’m going to mark this thread as resolved – if you stumble across any other issues, just open up a new support request 🙂

    PS: I just opened a new thread about Feature Requests. If there’s anything new that you would like to see in the plugin, drop a comment there.

    Thread Starter David Artiss

    (@dartiss)

    6 years, 10 months ago

    Many thanks for that @nikolovtmw – it’s good to see you’ll be picking up Development.

    dfl1955

    (@dfl1955)

    6 years, 10 months ago

    Thanks Nikola, I have now installed it into one of the blogs, and it seems to work fine.

    • This reply was modified 6 years, 10 months ago by dfl1955.
Viewing 8 replies - 1 through 8 (of 8 total)
  • The topic ‘WordPress 4.8 and Super Emoji Plus breaks visual editor’ is closed to new replies.