Support » Alpha/Beta/RC » Widgets displaying / saving

  • Resolved Newb1e

    (@newb1e)


    I’m testing the WordPress 4.9 RC 2 on my developing multisite installation and tried out the new widgets.

    My custom theme and the twentyseventeen theme have problems with displaying the new default widgets Audio and Video.
    This is how it looks like in a sidebar: https://image.ibb.co/bQ3hyG/Screenshot_2017_11_9_Live_Preview_Loading.png
    In the Page Builder by SiteOrigin it looks the same (just not that compressed).

    Furthermore under appearence > widgets I’ve noticed that if you put the image widget in a widget area and type in a link without http:// at the beginning, you can’t save the widget, but there is no notice what’s going on. Just nothing happens.

Viewing 6 replies - 1 through 6 (of 6 total)
  • Newb1e

    (@newb1e)

    I’m testing the WordPress 4.9 RC 2 on my developing multisite installation and tried out the new widgets.

    My custom theme and the twentyseventeen theme have problems with displaying the new default widgets Audio and Video.
    This is how it looks like in a sidebar: https://image.ibb.co/bQ3hyG/Screenshot_2017_11_9_Live_Preview_Loading.png
    In the Page Builder by SiteOrigin it looks the same (just not that compressed).

    Furthermore under appearence > widgets I’ve noticed that if you put the image widget in a widget area and type in a link without http:// at the beginning, you can’t save the widget, but there is no notice what’s going on. Just nothing happens.

    Edit: I tested this again and it was only my own theme. At twentyseventeen I guess it was only a caching thing, now it works there as it should. The second problem with saving still exists.

    Weston Ruter

    (@westonruter)

    @newb1e Thanks, I’ve reported this to https://core.trac.wordpress.org/ticket/42488 and added a patch. Please test there.

    terrathemes

    (@terrathemes)

    Hi @westonruter

    Please test there.

    What exactly do you mean with this? How do I get the patch and where is “there”?

    This is my first bug report, so I’m quite unexperienced and would appreciate your instructions.

    Weston Ruter

    (@westonruter)

    @terrathemes Oh, of course.

    There is a patch file uploaded to that ticket: https://core.trac.wordpress.org/attachment/ticket/42488/42488.0.diff

    Here are some instructions on how to apply a patch: https://make.wordpress.org/core/handbook/tutorials/working-with-patches/#applying-a-patch

    Note that if you’re using a build version of WordPress, you’ll want to add define('SCRIPT_DEBUG', true) to your wp-config.php to avoid having to also patch the minified files.

    If you don’t want to patch the file with patch command, you can also just manually add the .media-widget-image-link > .link:invalid selector to wp-admin/css/widgets.css as seen in the diff.

    terrathemes

    (@terrathemes)

    @westonruter

    Thank you much for your explanation. In this case changing it manually seemed to easier. It solved the issue.

    Moderator Marius L. J.

    (@clorith)

    I’ll mark this thread as resolved, as there is an associated Trac ticket which appears to solve the issue, and where further discussions can take place.

Viewing 6 replies - 1 through 6 (of 6 total)
  • You must be logged in to reply to this topic.