WordPress.org

Support

Support » Plugins and Hacks » Where can I submit patches?

Where can I submit patches?

Viewing 9 replies - 1 through 9 (of 9 total)
  • Plugin Author Stefan Boonstra

    @stefanboonstra

    What exactly do you mean by making them accessible? I could send you the PhotoShop files if you’d like me to.

    For starters, a user should be able to navigate to and use each of the buttons using only a keyboard. Each of the buttons must also be described in some way so that a blind user can find them.

    I’m just about done updating the pause/play buttons to work this way and can send you a patch if you’d like to see what I mean.

    Plugin Author Stefan Boonstra

    @stefanboonstra

    That would be great! Could you please send me an e-mail at wordpress@stefanboonstra.com or create a GitHub repository with the adapted code?

    Stefan, I work with poorgeek – I sent an email to the address listed above regarding the best way we could contribute our changes to the plugin. Unfortunately due to the concatenation/minification of all the JavaScript in recent plugin releases, it’s difficult to apply some of the fixes we made.

    If you have time to respond to that email I’d really appreciate it – thanks!

    Plugin Author Stefan Boonstra

    @stefanboonstra

    Hi Ben,

    If you don’t mind, I’ll answer your question in this thread.

    All of the slideshow plugin’s files can already be found on GitHub. To be able to compile the slideshow’s script to a single file again, you’ll need a tool like Prepros or CodeKit.

    Best regards,
    Stefan

    Stefan,

    Thanks very much. I had found what I thought was your GitHub account, but it must have been someone else, and there were no public repositories.

    I will work on a pull request with our changes.

    Ben

    Plugin Author Stefan Boonstra

    @stefanboonstra

    Hi Ben,

    That’s great, I’ll await your pull request. Thank you very much.

    Best regards,
    Stefan

    I’m not familiar with CodeKit but I understand conceptually what it’s for. Do you use the default settings for things like minification or have you changed anything in preferences? I guess it doesn’t matter too much – I can just contribute the original source files and leave the minification/concatenation to you when you review the changes.

    Plugin Author Stefan Boonstra

    @stefanboonstra

    It doesn’t matter too much indeed. I use Prepros myself, as I’m on Windows. However, I haven’t changed any settings for minification.

    As long as the “js/min/all.frontend.min.js” and “js/min/all.backend.min.js” are created, the slideshow will work.

Viewing 9 replies - 1 through 9 (of 9 total)
  • The topic ‘Where can I submit patches?’ is closed to new replies.