Weird bug when setting focus point for Featured Image or ACF Image fields

  • Resolved 61pixels

    (@61pixels)


    3 months, 1 week ago

    When adding a Featured Image to a post. You click “set featured image” Choose the photo, then on the right click “Change” for the Media Focus point. It pops up the window, you set your position and click “save” in the upper right and it just closes the entire featured image window and never sets the featured image. It does in fact save the Focus Point though. So it involves multiple steps and seems clunky.

    With ACF Image fields, When you first upload the photo, if you click “change” for Media Focus Point, once you set the point, when you click “save” in the top right, the browser pops up “Leave Site? Changes you made will not be saved.”. If you click leave it just refreshses the page not saving anything. If you click cancel, you can successfully choose the photo, but the position isn’t saved.

    Clicking the edit icon on the Image in the ACF Image field, if you click “Change” for the Media Focus point, once again, you can change the point, but as soon as you click the save in the upper right, it completely closes the media dialog box (seems like it’s imitating clicking the “update file” button in the bottom right. It does retain the position though.

    I have been using this plugin for the past 6 months or so and I don’t remember it doing this previously. I feel like this is a new bug after the one update you made to fix the buttons appearing in the wrong spot.

    Uploading the media directly into the Media library works just fine once the image is uploaded and you click to edit it and change the position.

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author WP Company

    (@wpcompany)

    3 months ago

    Hi @61pixels,

    Thanks for submitting your ticket. We’ll look into this issue and let you know as soon as an update is rolled out.

    Thread Starter 61pixels

    (@61pixels)

    1 month, 2 weeks ago

    Hi there, any update on when the fix will be implemented? I did some digging and narrowed it down to your close_overlay() function in script.js around line 90. THe problem is you’re looking for .wpcmfp-media-modal-content which doesn’t exist when setting a featured image so it’s defaulting to submitting the post as if you’re on the media attachment screen. Replacing it with this code seems to fix all the issues.

    const isAttachmentEditPage = document.body.classList.contains(‘post-type-attachment’);
    if (isAttachmentEditPage && !document.querySelector(‘.media-modal’)) {
    const postForm = document.getElementById(‘post’);
    if (postForm) {
    postForm.submit();
    }
    }

    Plugin Author WP Company

    (@wpcompany)

    1 month, 1 week ago

    Hi @61pixels,

    I wasn’t able to reproduce the issue. However, I’ve implemented your suggested code changes, and everything still appears to be working correctly. I hope this has helped on your end as well after updating. Please let us know if you need anything further.

Viewing 3 replies - 1 through 3 (of 3 total)

You must be logged in to reply to this topic.