• In February 2023, GenerateBlocks released version 1.7 which changed the way the GenerateBlocks Container block functions: https://wordpress.org/plugins/generateblocks/. Prior to that plugin release, Wayfinder worked as expected with GenerateBlocks, but since, the padding (15px 12px) from the Wayfinder editor-style.css takes precedent over the actual GenerateBlocks Container block and Button block padding in the block editor: .block-editor-page.wayfinder-outline [data-title], .block-editor-page.wayfinder-classes [data-title], .block-editor-page.wayfinder-title [data-title]. That means the content display is the block editor is not accurate. You might say that the problem is with GenerateBlocks since Wayfinder was compatible previously and it isn’t now. I have reported the issue to the GenerateBlocks team, but felt the Wayfinder team should be made aware also as there might be an easy fix that Wayfinder could implement.

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Author themolitor

    (@themolitor)

    Hey Tim 👋

    Thanks for the heads up here!

    Wayfinder adds padding to blocks/elements to prevent the labels from overlapping so they are easy to identify and locate. While in some cases the extra padding does change the true appearance of elements as they are displayed on the front-end, it is felt that the main utility of Wayfinder is for displaying these labels to locate and identify specific blocks that need attention.

    Was Wayfinder padding not overriding GenerateBlocks before? This method was always applied to Wayfinder, so wondering what they changed exactly in the GenerateBlocks plugin.

    One possible solution I can think of is to disable the Wayfinder padding if the labels feature is turned off (with the outline feature still in effect). Would that work for how you use Wayfinder?

    Best,
    Christopher

    • This reply was modified 1 year, 1 month ago by themolitor.
    • This reply was modified 1 year, 1 month ago by themolitor.
    Thread Starter Tim in Seattle

    (@theframeguy)

    @themolitor, thanks for the reply. Wayfinder worked perfectly with GenerateBlocks prior to their version 1.7. They totally rebuilt the way their Container block works and now there is an issue. The GenerateBlocks team is looking into the issue today as I’ve given them access to my sandbox website. I can’t imagine I’m the only person impacted since GenerateBlocks is a 5-star rated blocks plugin with 100K+ installs. I just tested by turning off “Display block type” and it made me realize how much I actually depend on the block type display.

    Thread Starter Tim in Seattle

    (@theframeguy)

    @themolitor, I’ve heard back from the GenerateBlocks team. Here’s their reply, which might give you insight into what has changed in GenerateBlocks and why Wayfinder is now conflicting with it. Their example is with their Button block, but the same is true for their Container block.

    The old GenerateBlocks Button block used to always be inside the Buttons wrapper block, so they had this selector:
    .gb-button-wrapper .gb-button {
    /* CSS */
    }

    Now that the Button block can be by itself, it has a simpler selector:
    .gb-button {
    /* CSS */
    }

    Unfortunately, this makes it less specific and can leave it prone to being overwritten by more specific selectors. This is what’s happening with the Wayfinder plugin – they’re using a very specific selector. It may be worth reporting to them to see if they can lower the specificity.

    Plugin Author themolitor

    (@themolitor)

    Ahh, that makes sense. Thanks for reporting back on your findings!

    Only solution I can think of is building in an option/checkbox to specifically disable Wayfinder for GenerateBlocks classes/elements, which might make sense given its popularity.

    If I did add a checkbox for you to toggle on/off, what should it say? “Disable Wayfinder for GenerateBlocks elements”? 🤔

    Thread Starter Tim in Seattle

    (@theframeguy)

    People who use GenerateBlocks usually use it as their primary block package, so it’s used on every page and post. Therefore, if Wayfinder was incompatible with GenerateBlocks, there would be no reason to install it. So really, I don’t think a disable feature is needed. I’ve been testing the Editor Block Outline plugin by Kalimah Apps, and while it is compatible with the new GenerateBlocks, I don’t like it as much as Wayfinder.

    Plugin Author themolitor

    (@themolitor)

    Good to know! Will keep thinking on this for a solution 👍

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘Wayfinder conflict with new GenerateBlocks 1.7’ is closed to new replies.