Support » Plugin: PilotPress » Warning: Invalid argument supplied for foreach()

  • Resolved Till Krüss

    (@tillkruess)


    This error was reported over a year ago:

    
    Warning: Invalid argument supplied for foreach() in /wp-content/plugins/pilotpress/pilotpress.php on line 4067
    

    Why has this not been fixed?

    And no, we’re not going to adjust our error reporting for Ontraport’s bad code quality.

    The page I need help with: [log in to see the link]

Viewing 9 replies - 1 through 9 (of 9 total)
  • Till Krüss

    (@tillkruess)

    We have to maintain backward compatibility for all valid versions of PHP as well as different web server software, so the notices are unavoidable. If the site is otherwise working fine, you can turn the errors off.

    This is suck utter hogwash. You can maintain backwards compatibility and not throw notices if you’d put ¢2 of effort into this.

    Plugin Author ONTRAPORT

    (@ontraport)

    Hi Till, It’s primarily cause we failed to notice this bug and also that it has never been brought to our attention. Till you have. I’ll see if I can get that fix out ASAP.

    As for your comment about ” ¢2 of effort into this.” We’re sorry the code did not meet your expectation of code quality. To be frank, this was something written 10+ years ago and updates to them have been done on an as needed basis.

    Plugin Author ONTRAPORT

    (@ontraport)

    Hmm. I do see (https://wordpress.org/support/topic/php-errors-in-pilotpress-2-0-3/) which is where you saw it.

    THis was never escalated to the engineering team.

    Till Krüss

    (@tillkruess)

    Hey!

    Hi Till, It’s primarily cause we failed to notice this bug and also that it has never been brought to our attention.

    The error was reported and brought to your teams attention over a year ago here and shutdown: https://wordpress.org/support/topic/php-errors-in-pilotpress-2-0-3/

    I’ll see if I can get that fix out ASAP.

    That’d be amazing. I’ll change my rating if our issues are addressed.

    Till Krüss

    (@tillkruess)

    THis was never escalated to the engineering team.

    Got it. Maybe this was just poorly maintained. Glad you guys are more active now.

    Plugin Author ONTRAPORT

    (@ontraport)

    Update on this. Seems like this was escalated to the engineering team and then lost in the shuffle. The in_array stuff has now been fixed internally and after some testing should be released sometime this week.

    Thanks for the report.

    Till Krüss

    (@tillkruess)

    Fantastic!

    Plugin Author ONTRAPORT

    (@ontraport)

    Those warnings should be fixed.

    Amazing, thank you!

Viewing 9 replies - 1 through 9 (of 9 total)
  • You must be logged in to reply to this topic.