WordPress.org

Ready to get started?Download WordPress

Forums

Formidable Forms
Very strange... (6 posts)

  1. Gregory Karpinsky (@tivnet)
    Member
    Posted 1 year ago #

    First impression: Wow! These guys made something impressive! Even the free version looks great. Let's test a bit and go get the pro!

    But then, right after the first click:

    Notice: Undefined index: custom_style in plugins\formidable\classes\views\frm-entries\form.php on line 4

    Notice: Undefined index: before_html in plugins\formidable\classes\views\frm-entries\form.php on line 11

    Notice: Undefined index: after_html in plugins\formidable\classes\views\frm-entries\form.php on line 55

    and then I look in the code.... what a mess...

    Gentlemen, you just lost a client.

  2. sswells
    Member
    Plugin Author

    Posted 1 year ago #

    Try as I may, I'm not able to replicate. Which version are you using, and what did you do to cause this?

    Would you like to provide more detail about why you feel the code is a mess?

  3. Gregory Karpinsky (@tivnet)
    Member
    Posted 1 year ago #

    Which version? The only you have here. Just installed yesterday.
    Cannot reproduce? Turn debug output on. Or just look at those lines in your code, and you will see that you do not check if the values exist.

    About the "mess":

    You write things like
    return self::display_forms_list($params, '', false, false, $errors);
    having void display_forms_list. So, what are you returning exactly?

    Even worse example of the same:
    __FRMSAVED="<?php esc_attr(_e('Saved', 'formidable')) ?>";
    What esc_attr? _e() does not return anything. It prints.

    setup_edit_vars($record, $table, $fields=''
    $fields is array. Why default value is string?

    And so on. That in my eyes is a mess.

    In addition to that, you infest the global space with your variables and defines. I do not want to use a plugin that has so many globals. Especially, with such simple prefix, 'frm_'. Defines must be replaced with class constants. All globals must be replaced with only one, if you really need it.

    Sorry.

  4. sswells
    Member
    Plugin Author

    Posted 1 year ago #

    self::display_forms_list() returns the list of forms. I'm not seeing the problem there.

    You're right that esc_attr(_e( is bad and incorrect. This is a simple bug that has already been fixed in v1.07.02. We have removed a lot of the globals and defines as well in v1.07.02.

    We are continually working to improve this plugin, both what you see and what you don't. We appreciate your suggestion of combining the globals into one, and move defines to constants. We don't profess to know everything, and pointers on improvement are appreciated. Thanks!

  5. sswells
    Member
    Plugin Author

    Posted 1 year ago #

    By the way, the undefined index messages look like a plugin conflict. We'd appreciate it if you would go through your plugins and tell us which one is causing the problem. You're right that there isn't a check there to see if the value exists, but it is checked upstream when the $values array is set.

  6. sswells
    Member
    Plugin Author

    Posted 1 year ago #

    We found your list of notices by the way. You were trying to add an entry to a form with no fields.

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic

Tags

No tags yet.