Version 4.1.9.3 breaks wp-admin

We’re on PHP 8, by the way.

Looking at the documentation for ftp_nlist, it seems that the behavior of the first parameter was changed. Perhaps the first parameter was allowed to be null in PHP <8 but not in PHP >8?

• This reply was modified 3 years, 8 months ago by pikamander2.

Interestingly, it breaks some of our PHP 8 sites but not others. Weird.

Here are the two lines in \app\Common\Utils\Filesystem.php that are causing the TypeError:

public function exists( $filename )
{
...
return $this->fs->exists( $filename );
}

public function getContents( $filename )
{
...
return $this->fs->get_contents( $filename );
}

It appears that these two functions are supposed to fall back to using @file_exists and @file_get_contents if $this->isWpfsValid() returns false, but for some reason that’s not happening here.

A workaround that I found is to modify the two functions to always use the fallback code:

public function exists( $filename ) {
    return @file_exists( $filename );
}

public function getContents( $filename )
{
    if ( ! $this->exists( $filename ) ) {
        return false;
    }
    return @file_get_contents( $filename );
}

But I’m not sure what the underlying issue is.

• This reply was modified 3 years, 8 months ago by pikamander2.
• This reply was modified 3 years, 8 months ago by pikamander2.
• This reply was modified 3 years, 8 months ago by pikamander2.
• This reply was modified 3 years, 8 months ago by pikamander2.
• This reply was modified 3 years, 8 months ago by pikamander2.
• This reply was modified 3 years, 8 months ago by pikamander2.