Looks good…will test and let u know if there is any issue
@ash707 Thank you, hopefully it worked well.
Hi Lawrence,
It’s working like a charm. If there are any issues will let you know. Also the support for this plugin in fact (Free Plugin) seems to be awesome. Back in the days I had to wait for a few days to get support now all I can see is quick response. Thumbs up For this plugin and support.
Hi Lawrenceowen,
First, thank you very much for all the modifications that you made to improve the plugin. It’s really thrilled to work with a responsive support team. 🙂
I’ve tested the last version 2.0 beta. It works really well. But I found an issue. The city of the shipping address is not printed on the receipt. And when I check star-cloudprnt-for-woocommerce / order-handler.php, I find this: $ city = $ gkv ('_ shipping_citye', $ order_meta);
Is it normal?
Thanks,
@vosab Thanks for checking the beta, and good catch, that is definitely a bug. Thank you for letting me know.
I’ll push a fixed version 2.0 beta 03 to the download area later today.
I have uploaded the beta 03 now, please download from the same link. I’ve also done an initial test with the newly released WooCommerce 5.0.0 and updated the compatibility information accordingly.
@lawrenceowen
Thank you for improving the plugin. It’s really working well.
By the way, I have a question.
Are you planing to add i18n support in the near future?
I usually use the plugin on Japanese websites, and I would be very happy if it supports i18n.
Until now, I have been using i18n by creating an extension plugin to support it.
https://github.com/ko31/star-cloudprnt-for-woocommerce-plus
@ko31
Thank you for testing it. and also for your nice modified version which I have suggested to several customers.
Yes, I completely intend to add i18n support. I’m also aware of some text alignment issues when using full-width characters like Kanji, which I hope to resolve soon (unfortunately the php “mb_*” functions don’t all work as well as I had hoped).
I didn’t want to introduce too many changes with 2.0 and risk introducing bugs or generating a lot of support requests. Instead it’s intended to add the most frequently needed changes and act as a base for introducing new features more rapidly, like i18n and templating. My main point of concern with the 2.0 release is the change in hook used for the print trigger, since it depends on the order status, but not all sites follow the same order status sequence.
The underlying changes mean that your modification will not be able to merge in to 2.0 directly, sorry about that. But development has shifted to GitHub, and from 2.0 onwards, the repository will be made public. Contributions, and pull requests will be very welcome.
I have absolutely no existing experience of i18n with WordPress, so will do some research before pushing any commits, but essentially I’m expecting to follow your way.
I know that you have also added useful hooks/filters, which I will not put into the Star version immediately. They are very useful, but may conflict with the template/theming support that I’m planning, so I will wait and implement those together. So you may still need to maintain a separate fork for a while?
@lawrenceowen
Thank you for replying.
That’s great idea! I don’t think you need to merge any risks into the plugin.
I am also looking forward to the release of the stable 2.0.
When the repository is made public in the future, I would like to contribute what I can.
Hi 🙂
Is there any GitHub Version avl. of this PlugIn?
So i can contribute?
Or how is it considered?
Thanx a lot for any Hint…
@cloudmeister We have moved the project to GitHub recently, and will be making it public very soon – I hope within a week or two (but please don’t hold me accountable for that, it depends on other priority work).
In the mean-time, if you would like to submit some changes then please get in contact with us directly in the UK office to get put in direct contact with me.
