Version 1.4.16 fatal error with PHP 5.3 and 5.4

Resolved dccharron
(@dccharron)

7 years, 8 months ago

Sorry to advise that version 1.4.16 is generating a fatal error (with PHP 5.3 and 5.4). More specifically:

Fatal error: Can't use method return value in write context in /home/content/02/10323502/html/htbr/wp-content/plugins/popup-maker/includes/pum-condition-functions.php on line 74

Using FTP I’ve renamed the directory in wp-content/plugins/popup-maker to popup-maker.bad to resurrect the website and get into dashboard. I’ve upgraded to PHP 5.4 and tried again but it didn’t help. Same error.

I’ll hold off upgrading any other of my sites until I hear from you.

PS. I’d love to move to PHP 5.6 but GoDaddy only offer up to 5.4. They are very conservative.

https://wordpress.org/plugins/popup-maker/

Viewing 8 replies - 1 through 8 (of 8 total)

bbbbho
(@bbbbho)

7 years, 8 months ago

roll back to 1.4.15

Chrissy
(@paperkawaii)

7 years, 8 months ago

same issue here. rolling back…

Plugin Author Daniel Iser
(@danieliser)

7 years, 8 months ago

Hey guys, just set the stable tag back to v1.4.15 so others don’t get this, looking into it now and will get a patch out asap.

Did extensive testing, so not sure how this slipped through.
Plugin Author Daniel Iser
(@danieliser)

7 years, 8 months ago
Found it, simple fix, can anybody test?

In the file popup-maker/includes/pum-condition-functions.php replace lines 74-93 with:
```
$templates = wp_get_theme()->get_page_templates();

		if ( $name == 'page' && ! empty( $templates ) ) {
			$conditions[ $name . '_template' ] = array(
				'group'    => $post_type->labels->name,
				'name'     => sprintf( _x( '%s: With Template', 'condition: post type plural label ie. Pages: With Template', 'popup-maker' ), $post_type->labels->name ),
				'fields'   => array(
					'selected' => array(
						'type'        => 'select',
						'select2'     => true,
						'multiple'    => true,
						'as_array'    => true,
						'options'     => array_flip(
							array_merge(
								array( 'default' => __( 'Default', 'popup-maker' ) ),
								$templates
							)
						),
					),
				),
				'callback' => array( 'PUM_Condition_Callbacks', 'post_type' ),
			);
		}
```
Plugin Author Daniel Iser
(@danieliser)

7 years, 8 months ago

@dccharron, @bbbbho, @paperkawaii — ^^^. As soon as I confirm that is the only issue I can push a patch.

Concerned that if I push a patch with just that fix another issue may come up that this one hid. Likely not but hate to push another faulty patch.

Thread Starter dccharron
(@dccharron)

7 years, 8 months ago

Am trying it now.

Thread Starter dccharron
(@dccharron)

7 years, 8 months ago

Ok. Applied patch to 74-95. No error generated. I’ve run a test and all good. Thank you so much.

Plugin Author Daniel Iser
(@danieliser)

7 years, 8 months ago

@dccharron – Thanks for the confirmation. Pushing v1.4.17 now.

Thank you everyone for the quick reports of the issue.

Please take a moment to rate and review the plugin and or support once you have updated to the latest version. If everything is working please click that it Works for you.