Support » Plugin: Pre* Party Resource Hints » Version 1.5.3

  • Resolved lofesa

    (@lofesa)


    Hi
    First of all, thx for your work.
    About the new version, some issues:

    1.- Need to state in the change log that hints must be deleted and saved again because the new version stores the headers strings in the db, if not re-saved no headers are sent

    2.- Fonts (woff,woff2.. files) must have the crossorigin attribute always not only when they come from google fonts, included self-hosted fonts. I have solved this including my 2nd. domain in the if in the check_for_crossorigin function in the class-gktpp-insert-to-db.php file. I have not tested if not using these function. I have to set a if, to test if the hint is a font to not include the crossorigin in others hints.

    3.- The values of as and type must be double quoted (as=”font”;type=”font/woff2″) so I have changed these lines

    $header_as_attr = " as=\"$as_attr\";";
    $header_type_attr = " type=\"$type_attr\";";

    4.- This line is wrong:
    $header = "<$url>; rel=$hint_type;$header_as_attr$head_type_attr$header_crossorigin";

    must be:
    $header = "<$url>; rel=$hint_type;$header_as_attr$header_type_attr$header_crossorigin";

    • This topic was modified 2 years, 3 months ago by lofesa.
    • This topic was modified 2 years, 3 months ago by lofesa.
Viewing 1 replies (of 1 total)
  • Plugin Author Sam Perrow

    (@samperrow)

    Thanks for catching those things. I just released version 1.5.3.1 which fixes all those issues.

    For #3, I have used as and type with single quotes when the links are used in the head, and without quotes when in the header with no problem, just as the other attributes are set. So for the time being I plan to keep it the same until I hear double quotes must be used.

Viewing 1 replies (of 1 total)
  • The topic ‘Version 1.5.3’ is closed to new replies.