Validation failure

  • Resolved ttodua

    (@ttodua)


    4 years, 2 months ago

    Hi.
    I think you have a bit minor inconsistency in plugin structure. My checker says that in your plugin, under “assets” folder you should be using still custom .php codes, instead that directory should be dedicated to static files (and I agree per WP Standards).

    It would be better if you migrate those .php files (like survey or notification .php files) into other folders, like “inc”, and change index.php files in “assets” directory with more acceptable index.html

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author chriscct7

    (@chriscct7)

    4 years, 2 months ago

    As a person who wrote a good deal of WordPress’s code standards page that’s definitely not a standard of the core project, nor of code standards guidance issued to plugins (I’m one of the Plugin team members as well).

    WordPress does not provide guidance on how plugins should be structured nor on any sort of restrictions revolving around file or folder names that are included in plugins.

    WordPress core notably doesn’t even use asset folders with the exception of a couple themes.

    • This reply was modified 4 years, 2 months ago by chriscct7.
    Thread Starter ttodua

    (@ttodua)

    4 years, 2 months ago

    I didn’t mention that WordPress Guideline or standards force that, just in following to WP Standards I mean the clear-code and clear-structure of plugins.
    and I dont think it would have been bad if what I suggested, was considered. as it’s a common though that in “assets” there are static files. Yes, no one forces, but is’t just a accepted practice, and seeing .php files (moreover, potentially vulnerable) is just not good practice.
    that was just my idea, nothing personal. good luck.

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Validation failure’ is closed to new replies.