[Resolved] v3.0.3 outputs CSS to page with no option to override or disable
In this latest version, you’ve chosen to output CSS directly to the page which is breaking layouts because of your use of float:left on the .addthis_toolbox container element. It looks like the breaking change was added in line 44 of addthis_sidebar_widget.php, and there is no option to disable or modify this. However, a good plugin should NEVER output
<style>blocks directly in the page, nor inline styles on elements whenever possible.
This is a lazy way to add/modify styles because it is not configurable, and it’s guaranteed to break layouts and themes for many users. Please be more considerate of developers’ own stylesheets and choose a better option, for example:
- add the styles to the .css file so that it can be properly overridden and cached
- add an option to disable raw output of CSS directly in the page (though
<style>blocks should NEVER be written in the body of the page!)
- or, use a WP filter to allow advanced developers to modify or remove this inline CSS
I would appreciate if you used one of my suggestions above and kept your code clean and configurable for developers who choose to use your plugin and the AddThis service. If every time I update this plugin it breaks my page, I will be motivated to quickly select an entire other social sharing service.
- The topic ‘[Resolved] v3.0.3 outputs CSS to page with no option to override or disable’ is closed to new replies.