• Resolved Tom

    (@narlytom)


    Hi,
    The latest version seems to break my website. All images no longer load, instead leaving large spaces, and some of the other css gets messed up.

    I can fix the absent images by turning off lazy loading of images in jetpack – so this part is a potential conflict with jetpack. But I wasn’t able to repair the broken CSS by disabling other potential clinflicts, including jetpack, W3 total cache and autoptimise.

    I restored a backup from yesterday, issue resolved, and then when I updated the module again – same issue recurs.

Viewing 12 replies - 1 through 12 (of 12 total)
  • Plugin Author Gabe Livan

    (@gabelivan)

    @narlytom Sorry about this inconvenience! I hope this is an isolated case and hopefully, we can debug it quickly in case it would affect others. Are you saying that when you’re reversing to https://downloads.wordpress.org/plugin/wp-asset-clean-up.1.3.6.0.zip everything just gets back to normal? Also, what do you see in the browser’s console? WHat kind of errors?

    Thread Starter Tom

    (@narlytom)

    Thanks for your super quick response Gabe!

    If I reverse to the previous version, then the site breaks completely and I get the WordPress critical error message. If I restore my backup from yesterday then it all works fine, until I update the plugin again.

    These are the two error messages in the console:

    Failed to set referrer policy: The value '' is not one of 'no-referrer', 'no-referrer-when-downgrade', 'origin', 'origin-when-cross-origin', 'same-origin', 'strict-origin', 'strict-origin-when-cross-origin', or 'unsafe-url'. The referrer policy has been left unchanged.

    autoptimize_2b3494b4409ab713562155a8f88daab7.js:2 Uncaught ReferenceError: jQuery is not defined
        at autoptimize_2b3494b4409ab713562155a8f88daab7.js:2
    Plugin Author Gabe Livan

    (@gabelivan)

    @narlytom so which version works fine for you? 1.1.6.0? Can you send me your “System Info” privately (as it contains sensitive information you might not want to publicly share) via https://gabelivan.com/contact/?

    Thread Starter Tom

    (@narlytom)

    Version 1.3.6.0 is the version that is working fine. 1.3.6.1 is the version that causes issues. I have sent you the site info.

    (Your contact page wouldn’t let me submit without an attachment, so I just attached a blank word document)

    Plugin Author Gabe Livan

    (@gabelivan)

    @narlytom I replied to your email. That error “jQuery is not defined” which is triggered by Autoptimize is due to the fact that either jQuery library is not loaded at all OR it is loaded, but with “defer” which would trigger it AFTER autoptimize_2b3494b4409ab713562155a8f88daab7.js is loaded (which could be render-blocking). Can you enable the plugin in “Test Mode” (https://downloads.wordpress.org/plugin/wp-asset-clean-up.1.3.6.1.zip) and disable combine JS in Asset CleanUp? I’m willing to reward you with an Asset CleanUp Pro license if you can help me out debugging this!

    artio01

    (@artio01)

    Hi Gabe,

    I can help you with this. I have the same problem and I tried to disable everything in Autoptimize, one by one. My findings: if you disable “Optimize HTML Code?” everything works ok. I don’t know technically why this happens but maybe could help you to debug the issue in your plugin.
    Maybe @narlytom could check if disabling the HTML Optimization in Autoptimize solves the problem.

    Have a nice day,

    Thread Starter Tom

    (@narlytom)

    Hey, thanks for your tip. Unfortunately this doesn’t seem to make any difference for me, the issue is still the same. Completely disabling autoptimise also doesn’t fix the problem.

    (Have obviously tried flushing all caches during this process too which hasn’t helped).

    Plugin Author Gabe Livan

    (@gabelivan)

    @artio01 thanks for this tip! I made extensive tests with “Optimize HTML Code?” turned on and off and I’ve noticed that whenever I have a very large HTML output (heavy page), it will return a blank page, most likely because of the lack of resources (not enough CPU / memory). This also happens when Asset CleanUp is deactivated. It does make sense though and it’s recommended to use an option such as minify HTML (doesn’t matter which plugin you use for it) together with a caching service (e.g. the one your hosting company might offer or a plugin generating static pages such as WP Rocket), ideally on a hosting package that has a strong CPU and lots of memory. Personally, I don’t like the minify HTML function much because it’s often breaking functionality and I don’t have websites with a huge amount of traffic.

    However, it looks like @narlytom has a different issue and I’ll check it out as soon as I can to make sure it’s solved and no one else would experience it (hopefully, it’s an isolated case).

    artio01

    (@artio01)

    I understand. I’m just describing my workaround used to solve the jQuery not defined errors after updating to 1.3.6.1.
    Maybe I have another plugin conflict than @narlytom but this modification in Autoptimize worked. I’m using an AWS Ubuntu machine with 2GB of Ram and using Nginx with PHP fast-cgi + w3tc + Autoptimize and Asset CleanUp.
    Anyway, if you want you can use my dev environment to check all this and maybe other configs to troubleshoot the new plugin version.

    Thread Starter Tom

    (@narlytom)

    I haven’t given up on this yet. I left it on the old version for a few weeks, and then I saw in the last few days – a. new version of autoptimise – to I updated both together – and now the issue seems to *mostly* have resolved itself.

    The image issue is fixed, but still some other issues remain – in particular the AJAX search (Search WP live AJAX search plugin) doesn’t;t work and some other elements of my theme don’t work (the clickable search button doesn’t bring up a search box) maybe this is Ajax based too?.

    I have completely wiped my asset CleanUp installation, but still the issue persists, but disappears when I disable the plugin.

    Interestingly it is only a problem for logged-out users. Logged in users work fine.

    I’ll keep working on it.

    • This reply was modified 4 years, 11 months ago by Tom.
    Thread Starter Tom

    (@narlytom)

    I’ve fixed it!

    And – it was the same fix as artio01.

    Disabling “Optimise HTML” in autoptimise fixes the problem.

    Thread Starter Tom

    (@narlytom)

    To clarify – with the optimise HTML option checked in autoptimise, then jquery is not loaded properly. Something in the latest version is conflicting with this setting.
    With this option disabled, everything works fine.

    I wonder if I was not able to replicate this sooner due to a CDN / caching issue, but thank you to artio01 for the tip.

Viewing 12 replies - 1 through 12 (of 12 total)
  • The topic ‘v1.3.6.1 breaks site’ is closed to new replies.