Thread Starter
tnn
(@noelforge)
Bottom line : NEVER use integration slug shortcodes, always use post ID shortcodes.
Otherwise this will burn your stuff to the ground
Bel
(@belimperial)
Hi @noelforge
Thank you for getting in touch, and we’re sorry the site encounters a timeout error on the frontend when the CSS class trigger is missing.
However, it should not cause anytime out when the CSS class trigger is missing. The popup will only not trigger on the page, and the page should still work.
We made test with and without the CSS trigger, and the site doesn’t encounter any timeout.
Here’s how we test it:
https://share.getcloudapp.com/wbuQ9epY
Could you share to us which page builder have you used to help us replicate the issue?
Thank you, and we look forward to your response.
Thread Starter
tnn
(@noelforge)
Hello !
Yes, I am using beaver builder, and honestly the plugin is great and thank you for that, but working with is like defusing a bomb. Extremely dangerous and uncertain.
I should precise that I am using your plugin within a “Global Themer Layout” ( my header ), so it is going to be triggered on every page.
Thread Starter
tnn
(@noelforge)
Try duplicating Beaver Builder layouts called from popups, it will break your site and renders 500 errors.
But I have to insist, this is BY FAR one of the most indispensable plugin that I have ever used, congratulations to all of the team.
I understand that theme builder compatibility is a tough problem, but the ability that your plugin provides to use theme builders within popups is just a game changer in my book. Really based
Thank you and thank everybody on your team, but there is something really wrong going on and I can’t use it properly which is absolutely infuriating, because it makes the whole plugin unusable
-
This reply was modified 2 years, 4 months ago by
tnn.
-
This reply was modified 2 years, 4 months ago by
tnn.
-
This reply was modified 2 years, 4 months ago by
tnn.
-
This reply was modified 2 years, 4 months ago by
tnn.
@noelforge – That is strange, we use Beaver Builder for all of our sites & popups, never seen anything like this. Have you tried reporting it to them as it actually sounds like their plugin is hanging when a template is used outside the main loop. That could occur with a popup of ours, or any other hidden div in the footer if its happening like you described.
Would likely have not much at all to do with our code and integrations with them as those are very minimal at best as both plugins tend to do things the “WordPress way” which means they should just tend to work without custom code, and that is how they have worked for several years now. This is the first report of trouble I’ve seen.
Keep in mind, the front end of our plugin is pretty simple, load some divs with your conotent in them, add some JS triggers based on settings. We minimize how our code interacts with 3rd party code in order to not deal with conflicts honestly.
> unless your popup tries to call a CSS class that doesn’t exist anymore, or that has been changed, or has not yet been created.
Also the above seems to indicate a misunderstanding of how our Click Triggers work, all we do is something akin to this
jQuery( '.pum-123, .popmake-123, .your-custom-selector').onClick()
If your css classes or selector changes, nothing will break, just might not trigger a popup any more if the element is no longer getting the onClick event added.
-
This reply was modified 2 years, 4 months ago by
Daniel Iser.
Thread Starter
tnn
(@noelforge)
Hi there Daniel.
First of all, thanks a lot for your exhaustive answer.
TLDR : I fixed the issue in a replicable (probably ) way.
Actually, I managed to fix the problem by accident on one of my sites a week ago, and I didn’t think much about it, until I came across the problem again on my second site.
So, I tried going through your hints methodically and tinkered with my install for a few hours, doing conflict test Popup per Popup, and so on.
I’ll spare you the details, but the issue was caused by the CSS Selector having the same name as the beaver builder page ( slug ) that the shortcode was trying to call ( my english isn’t very good, but this is the red stuff )
View post on imgur.com
In my case, the CSS selector was named “popup_1”, and the Insert Layout Shortcode was trying to call a beaver builder page which was also named “popup_1”
So, I renamed the beaver builder page to “popup_one” ( and the shortcode ) and the popup started working properly, after a few hours of trying.
I think that error can be replicated, not sure if my fix is good, but I’ll let you know.
Thanks again and have a nice day.
Thread Starter
tnn
(@noelforge)
But yeah, I don’t think that’s related to your plugin. Maybe just a beaver thing, or some conflict anyway.