Support » Plugin: Merge + Minify + Refresh » Use of PHP 7-only constants

  • Resolved Roy

    (@lev0)


    Getting this error:

    Notice: Use of undefined constant PHP_INT_MIN – assumed ‘PHP_INT_MIN’ in /home/USER/public_html/wp-content/plugins/merge-minify-refresh/merge-minify-refresh.php on line 121

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Author launchinteractive

    (@launchinteractive)

    Hi Roy,

    Try adding this to your wp-config.php:

    define(‘PHP_INT_MIN’, -999999);

    That’s not good advice when that constant usually evaluates to -9223372036854775808 (or -2147483648 on 32-bit systems). I think it’d be better if you correct the code that assumes everyone’s on PHP 7.

    Plugin Author launchinteractive

    (@launchinteractive)

    Thats true, however we are just using the constant to make sure that an action fires before everything else. In most cases -999999 should be fine (You could set it to -9223372036854775808 if you wanted).

    PHP_INT_MAX is also used so you might want to define that to 9223372036854775807.

    Normally I would add a fix for this but seems as PHP <= 7.0 is out of active support I’m not sure its worth it. What do you think?

    Sure, *you* are only using it for that, but what about other code relies on it, would correctly create it when it doesn’t exist, but finds that broken value?

    5.6 Is supported until the end of this year, and you can bet that a huge number of web servers will keep running it after that since there are non-trivial changes that have to be made to your code.

    WP itself says it will run on 5.2.4+.

    Plugin Author launchinteractive

    (@launchinteractive)

    Like you said, being such a trivial change I’ve rolled it in. 1.8.10 is now released that should fix this.

    Cheers

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘Use of PHP 7-only constants’ is closed to new replies.